fix(studio): admitir captions vacíos en generation.music - #284
Merged
IAnMove merged 1 commit intoSep 9, 2026
Merged
Conversation
The closed music contract required a non-blank alt_prompt even though the generated schema defaults it to empty and ACE-Step accepts lyrics-only songs. Studio Generate and Wizard start_generation failed after writing lyrics or [Instrumental] without filling Style. Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen ejecutivo
Qué cambia
generation.musicya no exige un Style/caption (alt_prompt) no vacío. Letras solas o[Instrumental]vuelven a admitirse.Para qué sirve
El contrato cerrado de #280 pedía caption no vacío aunque el schema generado lo deja en
""y ACE-Step acepta canciones solo con lyrics. Generate y el Wizard fallaban en seco.Impacto para el usuario
En Studio → Audio → Music, Generate funciona si hay lyrics (o Instrumental) aunque Style esté vacío. MiniMax-Music3 sigue exigiendo caption en su handler.
Riesgo
Estado
Summary
The closed Studio music envelope required a non-blank
alt_prompton both sides:StudioMusicParams._check_semanticscalled_non_blank(self.alt_prompt)assertMusicParamscalledrequiredText(value.alt_prompt)The generated catalog only requires
promptandmodel_type;alt_promptdefaults to"". ACE-Step treats an empty caption as empty tags. The extra blank check blocked:prepare_audio+start_generationwhen the model omittedalt_prompt(the adapter writes'').The
_music_descriptionfield is intentionally not a caption fallback.This change removes only the non-blank caption checks. Lyrics/
promptremain required. Music3 still rejects a blank caption in its native handler.Overview
createStudioMusicGenerationCommand/freeze_studio_music_specnow admitalt_prompt=""or an omitted caption.Detailed changes
Backend
studio_music_spec.py: stop requiring a non-blankalt_promptin_check_semantics.UI and Wizard
musicGenerationSpec.ts: stop callingrequiredTextonalt_prompt. Catalog validation still enforces string/maxLength when the field is present.Data, provenance and compatibility
No sidecar or envelope version change. Commands that already sent a caption are unchanged.
Files and ownership
app/services/studio_music_spec.py— drop extra blank checkui/src/features/studio/musicGenerationSpec.ts— match generated catalogtests/test_studio_music_spec.py/ui/tests/musicGenerationCommands.test.ts— empty and omitted caption casesloadModelOptions, lyrics stash across Speech↔MusicValidation
Date (UTC): 2026-09-09
Base SHA: 60019e5 (
feat/shared-tool-commands)Head SHA: dfed48b
Validation scope: focused
python scripts/verify_clean_repo.pypython -m compileall -q app/services/studio_music_spec.py— OKFocused Python tests:
/workspace/.venv/bin/pytest tests/test_studio_music_spec.py -q— 39 passedcd ui && npm run i18n:checkUI tests:
npx tsx --tsconfig tsconfig.app.json --import ./tests/setupI18n.ts --test tests/musicGenerationCommands.test.ts— 9 passedcd ui && npm run lint -- --max-warnings=0cd ui && npm run buildgit diff --checkE2E/smoke checks: N/A (provider-free command tests; no live generation)
Code quality
main: pending CICI and review
CI of this HEAD: pending
Independent agent review of this HEAD: pending
Human merge click (operational, not code review): pending
Reviewed at current HEAD
Earlier review; HEAD has changed since (stale)
Pending
Unavailable
Coste de la tarea
Notes and limitations
Does not stash lyrics/caption across Speech↔Music, and does not stop
loadModelOptionsfrom resetting duration to the model default. Those remain on #280 / #283 follow-up.Follow-up work
loadModelOptionsshould clamp an in-range user duration instead of overwriting with the slider defaultChecklist