fix(viggle): show the complete video after sliding-window generation - #255
Merged
Conversation
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 54.9/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
IAnMove
marked this pull request as ready for review
September 7, 2026 23:04
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_557368ba-2cc7-4ed6-9857-0f97b13ba36e) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long Viggle runs save cumulative videos after each sliding window. Character Replacement selected the first video in the completed job's output list, showing about 5.17 seconds from a 31.7-second run. It now selects the last video in API registration order, which contains the complete result.
Selection remains scoped to that job, ignores non-video artifacts, and preserves the original output list and task identity. Image and audio selection are unchanged.
Validation:
119c9d391735641556bc3ea7ce8d45651f652f08.Tests simulate API status responses. This change has not been deployed to the running generation process.
Note
Low Risk
UI-only output selection in character replacement polling; behavior is narrower and covered by directed tests, with no auth or API contract changes.
Overview
Character replacement now picks the last video artifact in the completed job’s
output_fileslist (in API registration order), not the first match. Long Viggle runs emit cumulative window previews followed by the full render; the earlier logic surfaced only the first window (~5s) instead of the complete clip.Selection still filters to video extensions only, stays tied to that job’s status payload (no gallery fallback), and leaves image/audio completion paths unchanged. New tests cover mixed artifacts, non-alphabetic filenames, polling until completion, and explicit failure when the job completes without a real video file.
Reviewed by Cursor Bugbot for commit 52505dd. Configure here.