feat(video-editor): add timeline clips through the shared catalog picker - #251
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_eee012c9-d39b-4f01-8664-1828b8aaaa4e) |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Replace the ad-hoc HocusPocus multi-select modal with AssetExplorerDialog. Catalog confirm appends one clip via the existing probe path and keeps the current timeline, trims and order. Local multi-file import is unchanged.
IAnMove
force-pushed
the
grok/agente1-g1d2-videoeditor
branch
from
September 7, 2026 21:11
3b1484b to
8361e1f
Compare
Code healthQuality score: 54.7/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Ratchet passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen ejecutivo
Qué cambia
El Video Editor deja el modal propio de catálogo (multiselección + Load more) y abre el explorador compartido. Confirmar añade un clip al final del montaje.
Para qué sirve
VID-11: mismo picker que Studio, búsqueda/paginación remota, sin resetear timeline, trims ni orden. Importar varios archivos locales sigue igual.
Impacto para el usuario
From HocusPocus abre el explorador común. Choose añade un clip; Cancelar no toca el montaje. Para varios vídeos de biblioteca se confirma uno a uno.
Riesgo
Estado
Summary
G1-D2: VideoEditorPanel catalog add uses
AssetExplorerDialog.input type=file+ drop.ApiOutput→ probe source viavideoEditorClipFromOutputandaddSource, which appends.Overview
Opening From HocusPocus lazy-loads the shared explorer with remote pages of 24 and video-only constraints. Confirm closes the explorer and probes the chosen URL. Close/Escape does not call add. Local multi-import and handoff/replacement flows are untouched.
Detailed changes
Backend
None.
UI and Wizard
VideoEditorPanel.tsx: drop custom picker state/UI; lazyAssetExplorerDialog.videoEditorCatalogPick.ts: URL/thumbnail from catalog row.Data, provenance and compatibility
Draft storage format unchanged. Clip
sourceis still the workspace file name aftereditorSourcePath.Files and ownership
ui/src/features/video-editor/VideoEditorPanel.tsxui/src/features/video-editor/videoEditorCatalogPick.tsui/tests/videoEditorPicker.test.tsxLeft untouched: AlternativeSongs (VID-12), Studio VideoEdit/MultiClip (#250), Story/Wizard/Scene3D.
Validation
Date (UTC): 2026-09-07
Base SHA: 5e08edb
Head SHA: 3b1484b
Validation scope: focused
python scripts/verify_clean_repo.pypython -m compileall -q app/services app/launch.py scriptsFocused Python tests: N/A
cd ui && npm run i18n:checkUI tests:
npx tsx --tsconfig tsconfig.app.json --test tests/videoEditorPicker.test.tsx— 3/3 passcd ui && npm run lint -- --max-warnings=0cd ui && npm run buildgit diff --checkE2E/smoke checks: N/A (picker contract; explorer not opened; no GPU)
Code quality
main: pending CICI and review
Coste de la tarea
Notes and limitations
Catalog add is one clip per confirm (nucleus does not take a global multi-select). Local import still accepts multiple files. Tests do not open the explorer.
Follow-up work
G1-D3 AlternativeSongsDialog (VID-12). G1-HUI Director UI after Studio is stable.
Checklist
Note
Low Risk
Frontend-only picker swap with a deliberate UX change (single library clip per pick); no backend or auth changes.
Overview
From HocusPocus in the video editor now opens the shared
AssetExplorerDialog(lazy-loaded) instead of the old in-panel modal with paginatedfetchOutputs, shift-range multi-select, and batch Add.Choosing a catalog row closes the explorer and appends one video clip via
addCatalogOutput→videoEditorClipFromOutput→ existingaddSource/ probe flow. Constraints are video-only andmaxCount: 1, so library clips are added one confirmation at a time; Import and drag-and-drop still accept multiple local files. Timeline, trims, draft persistence, and handoff paths are not intentionally changed.Tests drop the multi-select picker scenario and add coverage for catalog URL binding and that the panel shows Import / From HocusPocus without mounting the explorer until opened.
Reviewed by Cursor Bugbot for commit 3b1484b. Configure here.