feat(studio): bind Omni mixed references with the shared picker - #247
Merged
Conversation
Add catalog picks one at a time under the model quota. Video soundtrack audio stays on the same reference id, not a stale list index. Local multiple drop remains.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_91ce7ec0-0323-4963-a370-12a83236e0ca) |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 54.7/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
G1-C3: Omni mixed references use AssetInput.
Test plan
omniReferencePicker.test.tsxNote
Low Risk
Studio sidebar UI change reusing existing asset-picker helpers; local multi-upload behavior is unchanged.
Overview
Omni mixed references now use the shared
AssetInputflow so users can add image/video/audio from the workspace catalog as well as from the device, alongside the existing multi-file drop/upload area.Catalog picks go through
chooseCatalog, which enforces per-type and totalomni_reference_limits, builds references withstudioMediaPath/applyChosenStudioMedia, and appends one item at a time. For video rows, attach/replace soundtrack no longer uses a hidden file input anduploadAudio; it usesAssetInputover workspace audio andchooseItemAudio, which patches the matching reference byid.Adds
omniReferencePicker.test.tsxto assert the add slot shows library vs. computer origins without opening the asset explorer, and registers that test inarchitecture_wire_inventory.json.Reviewed by Cursor Bugbot for commit 2a79ad5. Configure here.