Skip to content

feat(studio): bind Omni mixed references with the shared picker - #247

Merged
IAnMove merged 1 commit into
developmentfrom
grok/agente1-g1c3-omni
Sep 7, 2026
Merged

feat(studio): bind Omni mixed references with the shared picker#247
IAnMove merged 1 commit into
developmentfrom
grok/agente1-g1c3-omni

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

G1-C3: Omni mixed references use AssetInput.

  • Catalog add is one-by-one and respects image/video/audio/total caps.
  • Attached audio is stored on the reference id, not the list index.
  • Local multiple drop is unchanged.

Test plan

  • omniReferencePicker.test.tsx
  • eslint

Note

Low Risk
Studio sidebar UI change reusing existing asset-picker helpers; local multi-upload behavior is unchanged.

Overview
Omni mixed references now use the shared AssetInput flow so users can add image/video/audio from the workspace catalog as well as from the device, alongside the existing multi-file drop/upload area.

Catalog picks go through chooseCatalog, which enforces per-type and total omni_reference_limits, builds references with studioMediaPath / applyChosenStudioMedia, and appends one item at a time. For video rows, attach/replace soundtrack no longer uses a hidden file input and uploadAudio; it uses AssetInput over workspace audio and chooseItemAudio, which patches the matching reference by id.

Adds omniReferencePicker.test.tsx to assert the add slot shows library vs. computer origins without opening the asset explorer, and registers that test in architecture_wire_inventory.json.

Reviewed by Cursor Bugbot for commit 2a79ad5. Configure here.

Add catalog picks one at a time under the model quota. Video soundtrack
audio stays on the same reference id, not a stale list index. Local
multiple drop remains.
@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_91ce7ec0-0323-4963-a370-12a83236e0ca)

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 3 file(s); +123/-30; React UI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • added: ui/tests/omniReferencePicker.test.tsx
  • modified: tests/fixtures/architecture_wire_inventory.json, ui/src/components/Sidebar/OmniReferenceSection.tsx

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Code health

Quality score: 54.7/100

Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.

Component Weight Current Change
Cyclomatic health 45% 54.4 +0.1
File concentration 25% 61.3 +0.0
Oversized-file debt 20% 36.9 +0.0
Modularity 10% 75.0 +0.0

Change vs PR base: +0.0 points.

Metric Value
Production LOC 264,054
Production files 698
Test LOC 92,879
Functions measured 17,033
Functions complexity ≥ 15 833
Maximum complexity 672
Policy code-health-policy-v1
HEAD 984231a65349d5151d192c1f8638c9a31ec8436b
Base 8de1629a30542cd2fe7dcf42ea7cab6feb97ecb9
UI measurement complete

Markdown, JSON catalogs and tests are out of this table. Only app/ runtime + ui/src TS/JS count.

Most complex functions

Complexity Where
672 app/wgp.py:7219 generate_video
381 ui/src/stores/useStore.ts:4053 Async method 'startGeneration'
355 app/_launch_runtime.py:23563 _run_generation
308 app/wgp.py:12359 generate_video_tab
268 ui/src/stores/useStore.ts:8600 Async method 'loadSettingsFromOutput'
258 app/services/director/planners/short_film.py:3433 ShortFilmPlanner._plan_story_driven
258 ui/src/components/Sidebar/SceneAnimatorPanel.tsx:493 Function 'SceneAnimatorPanel'
248 app/services/director_pipeline.py:13607 _run_video_generation
245 app/services/director_pipeline.py:7712 _run_pipeline
244 ui/src/features/agent/agentActions.ts:1145 Function 'parseAction'
226 app/services/director_pipeline.py:6541 update_comic_preview
225 ui/src/features/agent/agentActions.ts:2892 Async function 'executeAgentActions'

Trend vs baseline

Metric Δ
Production LOC +39
Test LOC +48
Functions ≥ 15 +0
Maximum complexity +0

Warnings

  • production LOC increased by +39

Ratchet passed.

@IAnMove
IAnMove merged commit 204ae08 into development Sep 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant