feat(studio): bind mixer tracks and optional SFX video with the picker - #246
Merged
Conversation
Base and overlay mixer slots stay independent. SFX video remains optional and clears explicitly. Catalog choices store server paths and duration from metadata, without re-uploading.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_c5c0f775-4339-4a1b-9455-cf88ccff44c9) |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 54.7/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Ratchet passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
G1-C2: Mixer base/overlays and optional SFX video use AssetInput.
Test plan
mixerSfxPicker.test.tsx(2)Note
Medium Risk
Changes how mixer and MMAudio SFX inputs resolve media paths, but mirrors existing studio picker wiring and keeps generation params the same shape.
Overview
Mixer and SFX sidebar controls now pick media through the shared
AssetInputflow instead ofFileUploadZoneplus direct uploads.For the mixer, the base track and overlay slots load workspace audio catalog items (or local/device picks via the dual-origin UI). Selection sets backend paths via
studioMediaPathand duration viaapplyChosenStudioMedia; offset/volume/mix behavior is unchanged. For SFX, the optional video guide uses the same pattern with workspace video items and still drivesvideo_guide/ duration when metadata is available.Adds
mixerSfxPicker.test.tsxto assert both surfaces expose library + computer origins without auto-opening the asset explorer, and registers the test in the architecture wire inventory.Reviewed by Cursor Bugbot for commit 1dadd55. Configure here.