feat(video3d): bind Scene3D slots with durable dual-origin refs - #227
Merged
Conversation
Replace blob object URLs and the ad-hoc explorer with AssetInput so local files upload once and catalog picks keep workspace+filename. Late choices after template/workspace change or during export are ignored.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 54.3/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.1 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
IAnMove
marked this pull request as ready for review
September 7, 2026 19:18
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_aef89687-3718-4b98-9a47-3619637c4890) |
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
G2-F: Scene3D slots (S3D-01..04, including drive/cafe roles) use shared AssetInput (From my computer / From HocusPocus).
blob:.workspaceId+filename(+ optionalassetIdif present).<select>, not the picker.Does not edit picker core (
asset-picker/, StudioSourceField). Agent1 G1-C0 may later attach catalog ids; this already forwardsidwhenApiOutputhas one.Do not merge until asked.
IDs
S3D-01..04. Templates re-counted after #204/#212 (cafe-dance, drive-*).
Base / HEAD
a8cabea4(development, feat(assets): migrate Studio edit sources to AssetInput #224)d2feff2eTest plan
ui/tests/scene3dSlotSource.test.mjs+scene3dStage.test.mjs— 22 passed (lock RAM, concurrency 1)Limits
No GPU, no live GLB visual QA, no full local
tsc -b.Note
Medium Risk
Changes how scene documents store asset bindings and when async picker commits apply; incorrect guards could drop valid selections or leave stale refs, but scope is limited to Scene3D workspace UI and parsing.
Overview
Scene3D slot sourcing moves from a modal explorer plus raw file input to the shared
AssetInput(local upload and workspace catalog), with slot media still constrained by role (images for background,.glbmodels elsewhere).Slot assignments now persist durable
sourceUrlvalues and an optionalsourceRef(workspaceId,filename, URL, optionalassetId) via newslotSourcehelpers.blob:/filesystem:URLs are rejected on commit and stripped on document parse so saved scenes do not keep ephemeral sources.commitSlotSourceChoiceapplies or clears bindings only when generation, template, workspace, and slot still match, and ignores changes while export is locked; template switches, workspace changes, and agent workflow loads bump a generation counter to drop stale picker callbacks.Workspace-scoped model and image lists are prefetched for the picker. Loaded GLB clip selection remains the existing local
<select>, unchanged.Reviewed by Cursor Bugbot for commit d2feff2. Configure here.