fix(ci): alinear contrato de marca y tests con HocusPocus - #22
Merged
Conversation
The main CI jobs were red after the rebrand and later Director/editor changes. Pin the visible HocusPocus copy, keep Maestro compatibility keys, and update Python/UI assertions that still expected Loreframe strings or older H3/editor contracts. Co-authored-by: THEINAOG <IAnMove@users.noreply.github.com>
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Extract editor draft helpers so VideoEditorPanel only exports the component, keep cylinder preview uniforms on refs, persist style-import job status under the lock, and update remaining source/H3 assertions to the current contracts. Co-authored-by: THEINAOG <IAnMove@users.noreply.github.com>
IAnMove
marked this pull request as ready for review
August 29, 2026 12:55
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
GitHub runners do not ship ffmpeg, so the thumbnail tests crashed with FileNotFoundError after the brand gate started reaching pytest. Skip them the same way mix-concat does, and install ffmpeg in CI so they run. Co-authored-by: THEINAOG <IAnMove@users.noreply.github.com>
The ffmpeg commit left UI code unchanged, but GitHub Actions hung for 20+ minutes on a single `npm run check` step. Cap job runtime and split the UI gate so a stuck runner fails fast and the failing step is visible. Co-authored-by: THEINAOG <IAnMove@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué fallaba en
mainLos dos jobs de CI estaban rojos en el merge de #20. No era un fallo de las PRs 16–20:
mainya arrastraba contratos y tests desfasados.scripts/check_brand_contract.pyseguía exigiendo copy de Loreframe Lab, así que el job cortaba antes de pytest.navigator, 503 vs “Pipeline not found”, receta de diálogo sin pista) y, en cuanto esos pasaran, lint con--max-warnings=0.ffmpegen un runner que no lo tiene.Qué cambia
editorDraft.ts._update_jobpersiste bajo el lock para no reescribir un cancel comointerrupted.ffmpeg; los tests de thumbnails se saltan si no está.timeout-minutesy el gate de UI partido en pasos (tests / lint / build+budget) para que un runner colgado falle rápido.Verificación
Local:
cd ui && npm run check: 294 tests, lint 0 warnings, build + budgetpython -m pytest -q: 1506 passed / 8 skippedGitHub (
b375d19, run 33254841409):