fix(recipe): no truncar el diálogo TTS al duration de la escena - #21
Closed
cursor[bot] wants to merge 1 commit into
Closed
fix(recipe): no truncar el diálogo TTS al duration de la escena#21cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Qwen3 treats duration_seconds as a hard cap. Multi-shot episodes use scene.duration as a per-shot fallback (often the short opening hold), so Auto-generate truncated later dialogue while mouth keyframes kept moving. Size each track from the shots and beats that actually use it. Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Owner
|
Superseded by #93 ( Closing the draft and keeping the branch. |
Owner
|
Closed as superseded by #93. Branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qwen3 (y el resto de motores de audio) tratan
duration_secondscomo tope duro.resolveAudiousabarecipe.scene.duration, que en un episodio multi-plano es solo el fallback por plano — a menudo el hold silencioso inicial, o más corto que el plano hablado.Trigger: receta tipo CharacterKit (hold 6s → plano hablado 9s, beat hasta 7.6s). Si
scene.durationse omite, el parser lo pone a 6s. Auto-generate cortaba 1.6s del final de la línea mientras la boca seguía animando.Fix:
recipeAudioDurationtoma el máximo de los planos y beats que usan esa pista, igual querecipeAssetDurationya hacía para placas H3.Tests: sceneRecipe, sceneRecipeAssets y characterKitEpisode (50 pass).