Skip to content

docs(assets): inventory media fields for the shared picker - #206

Merged
IAnMove merged 2 commits into
developmentfrom
docs/asset-picker-inventory
Sep 7, 2026
Merged

docs(assets): inventory media fields for the shared picker#206
IAnMove merged 2 commits into
developmentfrom
docs/asset-picker-inventory

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

Inventory

  • 97 campos in-scope (P2D, S3D, IMG, VID, TLS, AUD, CHR, STY, DIR, TPL).
  • Excepciones documentadas (JSON de escena/proyecto, LoRAs, código huérfano).
  • Selects de modelo/proveedor/resolución/enum/clips ya cargados marcados OOS.

Test plan


Note

Low Risk
Documentation-only; no runtime or UI behavior changes. Future picker work is scoped separately with explicit merge/coordination rules.

Overview
Adds PR 0 documentation for the planned universal asset picker: no UI code, only inventory and acceptance contract frozen against origin/development fae7d3f6.

ASSET_PICKER_MIGRATION.md introduces a field-level catalog (97 in-scope IDs across Studio, 2.5D/3D, Tools, Story, Director, templates, etc.), each with current origin, persistence, planned adapter, tests, and pending/partial status. It freezes UX for PRs 1–8: dual entry Desde mi equipo / Desde HocusPocus, transactional confirm (explicitly no double-click confirm vs today’s AssetExplorerDialog), RAM-bounded previews, identity via /api/v1/assets, plus OOS controls, JSON/LoRA exceptions, rg evidence, open questions, and ownership split (core PR 1–4 vs consumer PRs 5–8). Scene3DWorkspace migration is gated on open PR #204.

CURRENT_WORK.md bumps the verified development SHA to fae7d3f6, records #198 (real 3D scenes + initial explorer) as integrated, and lists this inventory branch as in progress alongside #204 coordination notes.

Reviewed by Cursor Bugbot for commit dd1f4f7. Configure here.

Freeze the dual-source UX contract and list every media field that must
migrate onto the shared explorer, with owners and #204 coordination.
@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_0c6fac01-9e35-4829-a56b-da085e14393f)

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: medium
Scope: 2 file(s); +441/-7; docs

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • medium — Very large file change (docs/development/ASSET_PICKER_MIGRATION.md)
    docs/development/ASSET_PICKER_MIGRATION.md adds 429 lines. Consider splitting the PR.

Changed files

  • added: docs/development/ASSET_PICKER_MIGRATION.md
  • modified: docs/development/CURRENT_WORK.md

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Code health

Quality score: 53.7/100

Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.

Component Weight Current Change
Cyclomatic health 45% 54.1 +0.0
File concentration 25% 60.3 +0.0
Oversized-file debt 20% 35.7 +0.0
Modularity 10% 71.3 +0.0

Change vs PR base: +0.0 points.

Metric Value
Production LOC 260,049
Production files 650
Test LOC 89,262
Functions measured 16,641
Functions complexity ≥ 15 821
Maximum complexity 670
Policy code-health-policy-v1
HEAD be81a491af85b07dbd4e9134679120eca5fe4c36
Base fae7d3f697d810bebf7e9ad8f749314da9bbd2b7
UI measurement complete

Markdown, JSON catalogs and tests are out of this table. Only app/ runtime + ui/src TS/JS count.

Most complex functions

Complexity Where
670 app/wgp.py:7164 generate_video
376 ui/src/stores/useStore.ts:4029 Async method 'startGeneration'
355 app/_launch_runtime.py:23505 _run_generation
308 app/wgp.py:12298 generate_video_tab
271 ui/src/stores/useStore.ts:8572 Async method 'loadSettingsFromOutput'
258 app/services/director/planners/short_film.py:3433 ShortFilmPlanner._plan_story_driven
257 ui/src/components/Sidebar/SceneAnimatorPanel.tsx:478 Function 'SceneAnimatorPanel'
248 app/services/director_pipeline.py:13607 _run_video_generation
245 app/services/director_pipeline.py:7712 _run_pipeline
244 ui/src/features/agent/agentActions.ts:1145 Function 'parseAction'
226 app/services/director_pipeline.py:6541 update_comic_preview
225 ui/src/features/agent/agentActions.ts:2892 Async function 'executeAgentActions'

Trend vs baseline

Metric Δ
Production LOC +0
Test LOC +0
Functions ≥ 15 +0
Maximum complexity +0

Ratchet passed.

@IAnMove
IAnMove merged commit 6e7fa3f into development Sep 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant