fix(i18n): Video 3D agent and export copy uses catalogs - #205
Merged
Conversation
Wizard/agent 3D messages, compositor status lines and world3d export errors now use scene3d EN/ES keys instead of hardcoded Spanish or English. Incremental i18n check covers the migrated phrases.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_c8a368a5-ce28-46d4-aa3e-123275a15053) |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 53.7/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
The Library composer was still hardcoded Spanish, so Chromium with the EN UI lock could not find the old locator. Catalogs now own the dialog and picker chrome; the review e2e uses the English strings.
setupI18n locks tests to EN, so locators cannot keep the old Spanish aria-names after the Library composer moved into scene3d catalogs.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
User-facing Video 3D / Wizard copy introduced with #198 was hardcoded (mostly Spanish, some English). UI language must come from i18n catalogs.
What
scene3d.agent.*keys for Wizard/agent save/export/rhythm/open messages.animator.*.stage.*viascene3dCopy(no React).Does not edit
Scene3DWorkspace(#204 owns that file). Clip binding messages are translated at the source inclips.ts.Checks
node scripts/check-i18n-catalogs.mjstsx --testscene3d + asset explorer (16)Cursor review: not run (quota). Do not merge until asked.
Note
Low Risk
Copy and i18n wiring only; behavior is unchanged aside from localized strings, with low regression risk beyond missing translation keys.
Overview
Moves Video 3D / Scene Animator user-facing strings from hardcoded English and Spanish into the
scene3di18n catalogs so they follow the active UI language.SceneAnimatorPanelnow usest('animator.*')for compositor status (presets, keyframes, character kits, templates, lab link) andt('agent.*')for Wizard/agent workflow handlers (scene open/save/export, layers, rhythm/choreography, errors). Effect dependencies includet.Non-React export/clip code gets a small
scene3dCopyhelper;exportFlow,exportMp4, andclipsthrow localizedstage.*errors instead of fixed English strings.en/esscene3d.jsongains the newanimator,stage, andagentkeys.check-i18n-catalogs.mjsadds the touched files to the pilot list and forbids the migrated literals from reappearing in source.Reviewed by Cursor Bugbot for commit a3ed444. Configure here.