fix(i18n): lock Video3D review to the real UI language key - #203
Merged
Conversation
The compositor follows hocuspocus-ui-language and the browser locale. The review renderer wrote i18nextLng and clicked English labels, so a Spanish host never found Scene name or Export MP4. Use the catalog copy, pin the real key, and translate the leftover English model-ready status.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_93738b37-e416-4c63-b675-4b35349a323c) |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 53.0/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
Playwright's ESM loader rejects catalog JSON without an import attribute, so the e2e helper now reads LANGUAGE_STORAGE_KEY from a tiny module. The renderer still uses animatorLabels via tsx.
IAnMove
added a commit
that referenced
this pull request
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Base: `origin/development` `ac0a2e5f`.
Note
Low Risk
Changes are limited to i18n strings, Playwright/render harness setup, and test tooling; no auth, API, or production runtime behavior beyond user-visible status text.
Overview
Playwright and the scene-template review renderer were failing when the browser locale was Spanish because tests looked for hardcoded English labels like Scene name / Export MP4, while
detectUiLanguage()ignoresi18nextLngand can follownavigator.language.This PR adds
lockUiLanguageto sethocuspocus-ui-language(and the welcome flag) before navigation, wires it intogotoApp, review E2E setup, andrender.mjs(withlocale: 'en-US'). Automation now targets copy fromanimatorLabels('en')instead of literal strings.SceneAnimatorPanel routes the last two English-only model status messages through
animator.modelsReady/animator.modelsTimeoutin the en/es catalogs.sceneAnimatorI18n.test.tsxguards language detection, catalog labels, panel strings, and the renderer script.Reviewed by Cursor Bugbot for commit 0a0b95e. Configure here.