fix(h3): abortar si la malla sigue por encima del tope de cuelgue - #18
Merged
Conversation
reduce_faces tragaba cualquier error y devolvía la malla original. El hang-fix llamaba a eso como red de seguridad, así que Quality/PBR con >200k caras seguía a textura/export si FaceReducer petaba y congelaba el host. Ahora el guardia aborta el job en ese caso. Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
This was referenced Aug 27, 2026
…anagement-de36 Co-authored-by: THEINAOG <IAnMove@users.noreply.github.com>
IAnMove
marked this pull request as ready for review
August 29, 2026 12:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


El hang-fix de Hunyuan3D (#14) añadió
guard_mesh_complexitypara no texturizar/exportar mallas de cientos de miles de caras. Esa red de seguridad delegaba enreduce_faces(), que traga cualquier excepción (OOM, topología incompatible, FaceReducer de v2 sobre una malla v2.1) y devuelve la malla original.Impacto
Quality/PBR (octree 384+) que genera >200k caras: si FaceReducer falla, el worker registra
Mesh simplification skippedy sigue a Paint/export con la malla densa. Eso pincha CPU/RAM y bloquea el driver GPU — exactamente la clase de cuelgue que #14 intentaba cerrar.Cómo reproducir
reduce_faceslanza (OOM o postprocesador incompatible).Qué cambia
reduce_face/target_face_num) sigue siendo best-effort: solo se aborta cuando se supera el límite que congela el host.Validación
pytest tests/test_model3d_hang_guards.py— 8 passed.Note
Medium Risk
Changes failure behavior on the critical path before GPU-heavy texturing/export; jobs that previously hung the host will now fail fast, which is intentional but affects high-octree quality runs when simplification fails.
Overview
Hunyuan3D mesh guarding no longer continues into texturing/export when face reduction cannot bring the mesh under the host hang limits (200k for texture, 400k for export).
guard_mesh_complexitynow distinguishes the target face count (userreduce_face/target_face_num, capped by the hang limit) from the hang_limit itself. After calling best-effortreduce_faces(which may return the original mesh on error), it raisesRuntimeErrorif the face count is still abovehang_limit, with guidance to lower octree resolution instead of freezing the machine.A new unit test asserts this fail-closed path when
reduce_facesreturns an unchanged oversized mesh.Reviewed by Cursor Bugbot for commit f4acade. Configure here.