forked from Blizaine/Maestro
-
Notifications
You must be signed in to change notification settings - Fork 1
chore: merge main into development #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
199bfb8
feat: reserve music generation IDs before inference with idempotent s…
IAnMove 325ad19
fix(ci): make local validation explicit and fail closed
IAnMove 150e052
docs: record agent QA policy without applying GitHub rulesets
IAnMove c38c8e7
fix: run UI validation in the current PATH, not a login shell
IAnMove 6725143
fix: do not continue --full after a failed UI build
IAnMove dc5d807
fix: do not treat missing music idempotency keys as silent dedupe
IAnMove a09ea53
fix: start only one MiniMax worker on concurrent music replay
IAnMove ad985ed
Merge pull request #143 from IAnMove/feat/music-submission-contract
IAnMove 6caeba5
Merge pull request #144 from IAnMove/fix/validation-contract
IAnMove 43f75b9
Merge pull request #145 from IAnMove/docs/agent-qa-policy
IAnMove b1c2510
Merge branch 'main' into development
IAnMove File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Publish wipes reserved task identity
Medium Severity
submit_music_generationstoresgeneration_id,candidate_id,command_id, andidempotency_keyon the TaskRegistry row, thenstart_story_music_candidates_jobpublishes the MiniMax job to the sametaskId. That publish upserts a replacementmetadataobject from jobprovenance(usually empty) and overwritesworkflow/title, so the reserved identity does not survive on the canonical task.Additional Locations (1)
app/services/music_submission.py#L284-L300Reviewed by Cursor Bugbot for commit b1c2510. Configure here.