Add option to filter by measurand#868
Merged
danielhuppmann merged 10 commits intoAug 5, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
=====================================
Coverage 95.0% 95.0%
=====================================
Files 64 64
Lines 6134 6191 +57
=====================================
+ Hits 5828 5884 +56
- Misses 306 307 +1 ☔ View full report in Codecov by Sentry. |
danielhuppmann
marked this pull request as ready for review
July 26, 2024 14:53
phackstock
approved these changes
Jul 29, 2024
phackstock
left a comment
phackstock
left a comment
Contributor
There was a problem hiding this comment.
One small comment, after that good to merge.
danielhuppmann
commented
Aug 5, 2024
Co-authored-by: Philip Hackstock <20710924+phackstock@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Name of contributors Added to AUTHORS.rstDescription of PR
This PR adds a feature to support filtering by a "measurand", i.e., a tuple (or iterable of tuples) of variable and unit
See the related discussion at IAMconsortium/nomenclature#360