Change "after" model validators to instance methods#601
Open
dc-almeida wants to merge 1 commit into
Open
Conversation
phackstock
requested changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Thanks for tackling this one @dc-almeida. There's some more changes required though from changing the model_validator from a classmethod to a normal instance method. I've outlined it for the first occurrence of the change but it applies to all of them.
| @model_validator(mode="after") | ||
| @classmethod | ||
| def check_native_or_common_regions( | ||
| cls, v: "RegionAggregationMapping" |
Contributor
There was a problem hiding this comment.
Since this is no longer a classmethod, the implementation needs to change slightly, see: https://pydantic.dev/docs/validation/latest/concepts/validators/#model-validators
Suggested change
| cls, v: "RegionAggregationMapping" | |
| self |
| cls, v: "RegionAggregationMapping" | ||
| ) -> "RegionAggregationMapping": | ||
| """Check that at least one of the following is provided: native or common regions.""" | ||
| if not v.native_regions and not v.common_regions: |
Contributor
There was a problem hiding this comment.
Suggested change
| if not self.native_regions and not self.common_regions: |
| @@ -201,7 +200,6 @@ | |||
| return v | |||
Contributor
There was a problem hiding this comment.
Suggested change
| return v | |
| return self |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #596