Register GRACE_v26 - #414
Conversation
danielhuppmann
left a comment
danielhuppmann
left a comment
There was a problem hiding this comment.
Thank you, see suggestions and comments below.
| @@ -0,0 +1,210 @@ | |||
| - GRACE v26: | |||
| - Oceania: | |||
There was a problem hiding this comment.
Native regions should have a prefix with the model-version-hierarchy.
| - Oceania: | |
| - GRACE v26|Oceania: |
| @@ -0,0 +1,31 @@ | |||
| model: GRACE v26 | |||
| native_regions: | |||
| - OCE: Oceania | |||
There was a problem hiding this comment.
Rename-targets must also include the prefix.
| - OCE: Oceania | |
| - OCE: GRACE v26|Oceania |
| - Trinidad and Tobago | ||
| - Uruguay | ||
| - Venezuela | ||
| - European Union: |
There was a problem hiding this comment.
Note that this isn't the (current) EU members, so better to rename to avoid confusion.
| - European Union: | |
| - GRACE v26|Europe: |
| - WAS: West Asia | ||
| - NAMR: North America | ||
| - SAMR: South America | ||
| - EU: European Union |
There was a problem hiding this comment.
| - EU: European Union | |
| - EU: GRACE v26|European Union |
There was a problem hiding this comment.
Will modify this and other issues. Should I then close the conversation and send a new pull request?
There was a problem hiding this comment.
You can simply push to your main branch and this current Pull Request will be automatically updated.
| - Western Sahara | ||
| - Zambia | ||
| - Zimbabwe | ||
| - GRACE v26|Rest of the World |
There was a problem hiding this comment.
Please add the countries-attribute here as well, so that (at least) Russia is listed in the native-region-definition file.
| # R9 regions | ||
| - European Union (R9): | ||
| - EU | ||
| - Reforming Economies (R9): | ||
| - RoW | ||
| - Latin America (R9): | ||
| - SAMR | ||
| - Middle East & Africa (R9): | ||
| - WAS | ||
| - AFR | ||
| - Other (R9): | ||
| - OCE | ||
| - EAS | ||
| - SEAS | ||
| - SAS | ||
| - NAMR |
There was a problem hiding this comment.
If only four of 9 regions can be mapped explicitly, better to remove the R9-mapping altogether to avoid confusion. Sorry for suggesting it earlier.
| # R9 regions | |
| - European Union (R9): | |
| - EU | |
| - Reforming Economies (R9): | |
| - RoW | |
| - Latin America (R9): | |
| - SAMR | |
| - Middle East & Africa (R9): | |
| - WAS | |
| - AFR | |
| - Other (R9): | |
| - OCE | |
| - EAS | |
| - SEAS | |
| - SAS | |
| - NAMR |
danielhuppmann
left a comment
danielhuppmann
left a comment
There was a problem hiding this comment.
Looks good, sorry for the many iterations!
2 participants
@danielhuppmann and @phackstock
GRACE_v26 will participate in the IAMC diagnostics exercise, and we are encouraged to register the model here.