Register C3IAM model - #412
Conversation
danielhuppmann
left a comment
danielhuppmann
left a comment
There was a problem hiding this comment.
This looks ok, thank you - but you may want to consider replacing the non-obvious abbreviation with longer, more descriptive names. See an example suggestion below.
| countries: Russian Federation | ||
| - C3IAM 3.0|India: | ||
| countries: India | ||
| - C3IAM 3.0|OBU: |
There was a problem hiding this comment.
It would be more intuitive to users to rename the region so that it doesn't use abbreviations
| - C3IAM 3.0|OBU: | |
| - C3IAM 3.0|Canada and Oceania: |
| - Japan: C3IAM 3.0|Japan | ||
| - Russia: C3IAM 3.0|Russia | ||
| - India: C3IAM 3.0|India | ||
| - OBU: C3IAM 3.0|OBU |
There was a problem hiding this comment.
| - OBU: C3IAM 3.0|OBU | |
| - OBU: C3IAM 3.0|Canada and Oceania |
|
Thanks a lot for the suggestion. We have added comments to clarify the abbreviations (e.g., OBU = Other Branches of Umbrella Group, OWE = Other Western Europe). We would like to keep the existing region names because they have been used consistently in our previous published studies, which helps maintain consistency across related analyses. |
danielhuppmann
left a comment
danielhuppmann
left a comment
There was a problem hiding this comment.
Looks good, thank you!
2 participants
This PR registers C3IAM_v3.0 by adding the model native region definitions and model mapping files following the nomenclature model-registration instructions.
Reviewers: @danielhuppmann @phackstock