Fix shift assignment in align_volume when mirroring#1066
Merged
Conversation
Collaborator
Author
|
Bug reported by @fede-pe |
|
Contributor
|
"... and for some reason incremented by 1" 😆 can this be considered another oier&fede aventura? my bug discovering skill are to their finest I confirm the issue disappeared, thanks for saving the world another day Oier ❤️ |
fede-pe
approved these changes
Feb 25, 2026
Collaborator
Author
|
Contributor
|
i never get tired of this ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When considering mirrors in
xmipp_align_volumethe shift was not properly handled (my mistake in https://github.com/I2PC/xmipp3/pull/1039/changes). When mirroring, its Z component needs to be flipped and for some reason incremented by 1.