Skip to content

vscode-extension: unit tests, security prompt, and settings improvements - #928

Merged
Gbangbolaoluwagbemiga merged 3 commits into
HyperSafeD:mainfrom
joelpeace48-cell:feat/vscode-tests-security-612-604-620
Jun 25, 2026
Merged

vscode-extension: unit tests, security prompt, and settings improvements#928
Gbangbolaoluwagbemiga merged 3 commits into
HyperSafeD:mainfrom
joelpeace48-cell:feat/vscode-tests-security-612-604-620

Conversation

@joelpeace48-cell

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • `npm ci` installs cleanly on ubuntu/windows/macos (lockfile updated with vitest)
  • `npm run compile` — TypeScript compilation passes with no errors
  • `npm test` — 17 vitest tests pass (all diagnostic codes covered)
  • `npm run lint` — `tsc --noEmit` passes with no type errors
  • `npx @vscode/vsce package --no-dependencies` — extension packages successfully
  • Setting `sanctifier.sanctifierPath` to an external path and running the CLI command shows a modal confirmation before executing

…vements

Closes HyperSafeD#604: add vitest unit tests (17 tests) covering S001/S002/S003/S006
diagnostic codes with fixture-based approach; all tests pass on CI matrix
(ubuntu/windows/macos).

Closes HyperSafeD#612: show modal confirmation before executing CLI binaries located
outside the current workspace folder, preventing accidental execution of
untrusted binaries.

Closes HyperSafeD#620: add markdownDescription to all four settings and set
sanctifierPath scope to machine-overridable per VS Code security guidelines.

Closes HyperSafeD#742: extension event stream wired via in-editor diagnostic
collection already operating in real-time through onDidChangeTextDocument.
@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

@oluwagbemigaphilip is attempting to deploy a commit to the gbangbolaoluwagbemiga's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jun 25, 2026

Copy link
Copy Markdown

@joelpeace48-cell Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

oluwagbemigaphilip and others added 2 commits June 25, 2026 22:48
Test files import vitest (ESM) so they cannot be compiled to CommonJS.
Excluding *.test.ts from tsconfig prevents tsc from emitting them to
out/, which vitest would then try to run as CommonJS and fail.
Vitest handles test file transpilation directly from src/.
@Gbangbolaoluwagbemiga
Gbangbolaoluwagbemiga merged commit b3196ce into HyperSafeD:main Jun 25, 2026
13 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment