Bugfix: DB path #146
Bugfix: DB path #146
Conversation
|
Automatic code review is enabled for this repository. Reviewing this PR now. |
![devloai[bot]](https://avatars.githubusercontent.com/in/886113?s=60&v=4){kind=small}
There was a problem hiding this comment.
The core DB path fix looks good, but there is a critical issue that needs to be addressed: the CI workflow file was accidentally modified to trigger on the wrong branch. This needs to be fixed by reverting back to "release/wheels". Additionally, consider adding warning logs for better error handling when persistence is enabled without a path.
.github/workflows/build_wheels.yaml
Outdated
| @@ -2,9 +2,9 @@ name: Build Wheels | |||
|
|
|||
| on: | |||
| push: | |||
| branches: ["release/wheels"] | |||
| branches: ["dev/patch-7"] | |||
There was a problem hiding this comment.
The workflow trigger branch should not be changed from "release/wheels" to "dev/patch-7". This appears to be an unintended change that could break the wheel building process. Please keep it as "release/wheels".
| branches: ["dev/patch-7"] | |
| branches: ["release/wheels"] |
| @@ -386,11 +386,12 @@ HResult HFFeatureHubDataEnable(HFFeatureHubConfiguration configuration) { | |||
| if (configuration.enablePersistence) { | |||
There was a problem hiding this comment.
The fix for handling persistenceDbPath looks good, but there's a missing warning log when persistenceDbPath is null and enablePersistence is true. This could help with debugging issues. Consider adding a warning log in this case.
No description provided.