-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sourcery refactored main branch #1
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to GitHub API limits, only the first 60 comments can be shown.
releaseDir(OlivaDiceCore.data.dataDirRoot + '/' + bot_hash) | ||
releaseDir(OlivaDiceCore.data.dataDirRoot + '/' + bot_hash + '/console') | ||
fileDir = OlivaDiceCore.data.dataDirRoot + '/' + bot_hash + '/console' | ||
releaseDir(f'{OlivaDiceCore.data.dataDirRoot}/{bot_hash}') | ||
releaseDir(f'{OlivaDiceCore.data.dataDirRoot}/{bot_hash}/console') | ||
fileDir = f'{OlivaDiceCore.data.dataDirRoot}/{bot_hash}/console' | ||
fileName = 'censor.json' | ||
path = fileDir + '/' + fileName | ||
path = f'{fileDir}/{fileName}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function readConfigListByHash
refactored with the following changes:
- Use f-string instead of string concatenation [×10] (
use-fstring-for-concatenation
)
releaseDir(OlivaDiceCore.data.dataDirRoot + '/' + bot_hash) | ||
releaseDir(OlivaDiceCore.data.dataDirRoot + '/' + bot_hash + '/console') | ||
fileDir = OlivaDiceCore.data.dataDirRoot + '/' + bot_hash + '/console' | ||
releaseDir(f'{OlivaDiceCore.data.dataDirRoot}/{bot_hash}') | ||
releaseDir(f'{OlivaDiceCore.data.dataDirRoot}/{bot_hash}/console') | ||
fileDir = f'{OlivaDiceCore.data.dataDirRoot}/{bot_hash}/console' | ||
fileName = 'censor.json' | ||
path = fileDir + '/' + fileName | ||
path = f'{fileDir}/{fileName}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function writeConfigListByHash
refactored with the following changes:
- Use f-string instead of string concatenation [×10] (
use-fstring-for-concatenation
)
res = [] | ||
if bot_hash in gCensorConfigList \ | ||
and 'censorList' in gCensorConfigList[bot_hash] \ | ||
and type(gCensorConfigList[bot_hash]['censorList']) is list: | ||
res = gCensorConfigList[bot_hash]['censorList'] | ||
return res | ||
return ( | ||
gCensorConfigList[bot_hash]['censorList'] | ||
if bot_hash in gCensorConfigList | ||
and 'censorList' in gCensorConfigList[bot_hash] | ||
and type(gCensorConfigList[bot_hash]['censorList']) is list | ||
else [] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function getConfigList
refactored with the following changes:
- Move setting of default value for variable into
else
branch (introduce-default-else
) - Replace if statement with if expression (
assign-if-exp
) - Inline variable that is immediately returned (
inline-immediately-returned-variable
)
releaseDir(OlivaDiceCore.data.dataDirRoot + '/unity') | ||
releaseDir(OlivaDiceCore.data.dataDirRoot + '/unity/censor') | ||
fileDir = OlivaDiceCore.data.dataDirRoot + '/unity/censor' | ||
releaseDir(f'{OlivaDiceCore.data.dataDirRoot}/unity') | ||
releaseDir(f'{OlivaDiceCore.data.dataDirRoot}/unity/censor') | ||
fileDir = f'{OlivaDiceCore.data.dataDirRoot}/unity/censor' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function initCensor
refactored with the following changes:
- Use f-string instead of string concatenation [×15] (
use-fstring-for-concatenation
) - Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring
)
consoleSwitchFile = 'switch.json' | ||
for dictConsoleSwitch_this in dictConsoleSwitch: | ||
botHash = dictConsoleSwitch_this | ||
releaseDir(OlivaDiceCore.data.dataDirRoot + '/' + botHash) | ||
releaseDir(OlivaDiceCore.data.dataDirRoot + '/' + botHash + '/console') | ||
consoleSwitchDir = OlivaDiceCore.data.dataDirRoot + '/' + botHash + '/console' | ||
consoleSwitchFile = 'switch.json' | ||
consoleSwitchPath = consoleSwitchDir + '/' + consoleSwitchFile | ||
releaseDir(f'{OlivaDiceCore.data.dataDirRoot}/{botHash}') | ||
releaseDir(f'{OlivaDiceCore.data.dataDirRoot}/{botHash}/console') | ||
consoleSwitchDir = f'{OlivaDiceCore.data.dataDirRoot}/{botHash}/console' | ||
consoleSwitchPath = f'{consoleSwitchDir}/{consoleSwitchFile}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function saveConsoleSwitch
refactored with the following changes:
- Hoist statements out of for/while loops (
hoist-statement-from-loop
) - Use f-string instead of string concatenation [×10] (
use-fstring-for-concatenation
)
res = reg_res | ||
return res | ||
return reg_res |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function formatSTRReplace
refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable
)
def init(plugin_event, Proc): | ||
OlivaDiceCore.msgReply.unity_init(plugin_event, Proc) | ||
def init(self, Proc): | ||
OlivaDiceCore.msgReply.unity_init(self, Proc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Event.init
refactored with the following changes:
- The first argument to instance methods should be
self
(instance-method-first-arg-name
)
def init_after(plugin_event, Proc): | ||
OlivaDiceCore.msgReply.unity_init_after(plugin_event, Proc) | ||
def init_after(self, Proc): | ||
OlivaDiceCore.msgReply.unity_init_after(self, Proc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Event.init_after
refactored with the following changes:
- The first argument to instance methods should be
self
(instance-method-first-arg-name
)
def private_message(plugin_event, Proc): | ||
OlivaDiceCore.msgReply.unity_reply(plugin_event, Proc) | ||
def private_message(self, Proc): | ||
OlivaDiceCore.msgReply.unity_reply(self, Proc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Event.private_message
refactored with the following changes:
- The first argument to instance methods should be
self
(instance-method-first-arg-name
)
def group_message(plugin_event, Proc): | ||
OlivaDiceCore.msgReply.unity_reply(plugin_event, Proc) | ||
def group_message(self, Proc): | ||
OlivaDiceCore.msgReply.unity_reply(self, Proc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Event.group_message
refactored with the following changes:
- The first argument to instance methods should be
self
(instance-method-first-arg-name
)
def poke(plugin_event, Proc): | ||
OlivaDiceCore.msgReply.poke_reply(plugin_event, Proc) | ||
def poke(self, Proc): | ||
OlivaDiceCore.msgReply.poke_reply(self, Proc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Event.poke
refactored with the following changes:
- The first argument to instance methods should be
self
(instance-method-first-arg-name
)
def friend_add_request(plugin_event, Proc): | ||
OlivaDiceCore.ordinaryInviteManager.unity_friend_add_request(plugin_event, Proc) | ||
def friend_add_request(self, Proc): | ||
OlivaDiceCore.ordinaryInviteManager.unity_friend_add_request(self, Proc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Event.friend_add_request
refactored with the following changes:
- The first argument to instance methods should be
self
(instance-method-first-arg-name
)
def group_invite_request(plugin_event, Proc): | ||
OlivaDiceCore.ordinaryInviteManager.unity_group_invite_request(plugin_event, Proc) | ||
def group_invite_request(self, Proc): | ||
OlivaDiceCore.ordinaryInviteManager.unity_group_invite_request(self, Proc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Event.group_invite_request
refactored with the following changes:
- The first argument to instance methods should be
self
(instance-method-first-arg-name
)
def group_member_increase(plugin_event, Proc): | ||
OlivaDiceCore.ordinaryInviteManager.unity_group_member_increase(plugin_event, Proc) | ||
def group_member_increase(self, Proc): | ||
OlivaDiceCore.ordinaryInviteManager.unity_group_member_increase(self, Proc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Event.group_member_increase
refactored with the following changes:
- The first argument to instance methods should be
self
(instance-method-first-arg-name
)
def heartbeat(plugin_event, Proc): | ||
OlivaDiceCore.pulse.unity_heartbeat(plugin_event, Proc) | ||
def heartbeat(self, Proc): | ||
OlivaDiceCore.pulse.unity_heartbeat(self, Proc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Event.heartbeat
refactored with the following changes:
- The first argument to instance methods should be
self
(instance-method-first-arg-name
)
if tmp_set_para != None: | ||
if tmp_set_para is None: | ||
tmp_reply_str = OlivaDiceCore.msgCustomManager.formatReplySTR(dictStrCustom['strShowGroupMainDiceNone'], dictTValue) | ||
else: | ||
dictTValue['tResult'] = tmp_set_para | ||
tmp_reply_str = OlivaDiceCore.msgCustomManager.formatReplySTR(dictStrCustom['strShowGroupMainDice'], dictTValue) | ||
else: | ||
tmp_reply_str = OlivaDiceCore.msgCustomManager.formatReplySTR(dictStrCustom['strShowGroupMainDiceNone'], dictTValue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function replySET_command
refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches
) - Use x is None rather than x == None [×2] (
none-compare
)
if not flag_is_from_master and tmp_reast_str in ['debug']: | ||
pass | ||
else: | ||
if flag_is_from_master or tmp_reast_str not in ['debug']: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function replyRR_command
refactored with the following changes:
- Swap if/else to remove empty if body (
remove-pass-body
) - Merge duplicate blocks in conditional (
merge-duplicate-blocks
) - Remove redundant conditional [×2] (
remove-redundant-if
) - Replace multiple comparisons of same variable with
in
operator (merge-comparisons
)
res = dictStrCustom['strPcSkillCheckError'] | ||
if tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_SUCCESS: | ||
res = dictStrCustom['strPcSkillCheckSucceed'] | ||
return dictStrCustom['strPcSkillCheckSucceed'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_HARD_SUCCESS: | ||
res = dictStrCustom['strPcSkillCheckHardSucceed'] | ||
return dictStrCustom['strPcSkillCheckHardSucceed'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_EXTREME_HARD_SUCCESS: | ||
res = dictStrCustom['strPcSkillCheckExtremeHardSucceed'] | ||
return dictStrCustom['strPcSkillCheckExtremeHardSucceed'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_GREAT_SUCCESS: | ||
res = dictStrCustom['strPcSkillCheckGreatSucceed'] | ||
return dictStrCustom['strPcSkillCheckGreatSucceed'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_FAIL: | ||
res = dictStrCustom['strPcSkillCheckFailed'] | ||
return dictStrCustom['strPcSkillCheckFailed'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_GREAT_FAIL: | ||
res = dictStrCustom['strPcSkillCheckGreatFailed'] | ||
return dictStrCustom['strPcSkillCheckGreatFailed'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_FATE_01: | ||
res = dictStrCustom['strPcSkillCheckFate01'] | ||
return dictStrCustom['strPcSkillCheckFate01'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_FATE_02: | ||
res = dictStrCustom['strPcSkillCheckFate02'] | ||
return dictStrCustom['strPcSkillCheckFate02'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_FATE_03: | ||
res = dictStrCustom['strPcSkillCheckFate03'] | ||
return dictStrCustom['strPcSkillCheckFate03'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_FATE_04: | ||
res = dictStrCustom['strPcSkillCheckFate04'] | ||
return dictStrCustom['strPcSkillCheckFate04'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_FATE_05: | ||
res = dictStrCustom['strPcSkillCheckFate05'] | ||
return dictStrCustom['strPcSkillCheckFate05'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_FATE_06: | ||
res = dictStrCustom['strPcSkillCheckFate06'] | ||
return dictStrCustom['strPcSkillCheckFate06'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_FATE_07: | ||
res = dictStrCustom['strPcSkillCheckFate07'] | ||
return dictStrCustom['strPcSkillCheckFate07'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_FATE_08: | ||
res = dictStrCustom['strPcSkillCheckFate08'] | ||
return dictStrCustom['strPcSkillCheckFate08'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_FATE_09: | ||
res = dictStrCustom['strPcSkillCheckFate09'] | ||
return dictStrCustom['strPcSkillCheckFate09'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_FATE_10: | ||
res = dictStrCustom['strPcSkillCheckFate10'] | ||
return dictStrCustom['strPcSkillCheckFate10'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_FATE_11: | ||
res = dictStrCustom['strPcSkillCheckFate11'] | ||
return dictStrCustom['strPcSkillCheckFate11'] | ||
elif tmpSkillCheckType == OlivaDiceCore.skillCheck.resultType.SKILLCHECK_NOPE: | ||
res = dictStrCustom['strPcSkillCheckNope'] | ||
return dictStrCustom['strPcSkillCheckNope'] | ||
else: | ||
res = dictStrCustom['strPcSkillCheckError'] | ||
return res | ||
return dictStrCustom['strPcSkillCheckError'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function get_SkillCheckReasult
refactored with the following changes:
- Use previously assigned local variable (
use-assigned-variable
) - Move assignments closer to their usage (
move-assign
) - Inline variable that is immediately returned (
inline-immediately-returned-variable
) - Lift return into if (
lift-return-into-if
)
if initList == None: | ||
self.data = [] | ||
else: | ||
self.data = initList | ||
self.data = [] if initList is None else initList |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Stack.__init__
refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp
) - Use x is None rather than x == None (
none-compare
)
if self.type == self.nodeType.NUMBER: | ||
return True | ||
else: | ||
return False | ||
return self.type == self.nodeType.NUMBER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function calNode.isNumber
refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp
) - Simplify boolean if expression (
boolean-if-exp-identity
) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast
)
if self.type == self.nodeType.OPERATION: | ||
return True | ||
else: | ||
return False | ||
return self.type == self.nodeType.OPERATION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function calNode.isOperation
refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp
) - Simplify boolean if expression (
boolean-if-exp-identity
) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast
)
if self.type == self.nodeType.TUPLE: | ||
return True | ||
else: | ||
return False | ||
return self.type == self.nodeType.TUPLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function calNode.isTuple
refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp
) - Simplify boolean if expression (
boolean-if-exp-identity
) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast
)
if self.data.isdigit(): | ||
return int(self.data) | ||
else: | ||
return 0 | ||
return int(self.data) if self.data.isdigit() else 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function calNumberNode.getInt
refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp
)
if self.data == '-': | ||
if self.data == '$t': | ||
self.valLeftDefault = 1 | ||
self.vals['='] = None | ||
elif self.data == '-': | ||
self.valStarterLeftDefault = 0 | ||
elif self.data == '?': | ||
self.valRightDefault = 0 | ||
self.vals[':'] = None | ||
elif self.data == 'a': | ||
self.vals['k'] = 8 | ||
self.vals['q'] = None | ||
self.vals['m'] = 10 | ||
elif self.data in ['b', 'p']: | ||
self.valLeftDefault = 1 | ||
self.valRightDefault = 1 | ||
elif self.data == 'c': | ||
self.vals['m'] = 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function calOperationNode.initOperation
refactored with the following changes:
- Simplify conditional into switch-like form (
switch
)
if self.resError == None: | ||
if self.resError is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function RD.roll
refactored with the following changes:
- Use x is None rather than x == None [×4] (
none-compare
) - Swap if/else branches [×2] (
swap-if-else-branches
) - Remove unnecessary else after guard condition (
remove-unnecessary-else
)
flag_enable_default = 1 | ||
flag_enable = 1 | ||
flag_enable = OlivaDiceCore.console.getConsoleSwitchByHash('autoAcceptGroupAdd', 'unity') | ||
flag_enable = OlivaDiceCore.console.getConsoleSwitchByHash('autoAcceptGroupAdd', plugin_event.bot_info.hash) | ||
if flag_enable == None: | ||
if flag_enable is None: | ||
flag_enable_default = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function unity_group_invite_request
refactored with the following changes:
- Move assignments closer to their usage (
move-assign
) - Use x is None rather than x == None (
none-compare
) - Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring
)
flag_enable_default = 1 | ||
flag_enable = 1 | ||
flag_enable = OlivaDiceCore.console.getConsoleSwitchByHash('autoAcceptFriendAdd', 'unity') | ||
flag_enable = OlivaDiceCore.console.getConsoleSwitchByHash('autoAcceptFriendAdd', plugin_event.bot_info.hash) | ||
if flag_enable == None: | ||
if flag_enable is None: | ||
flag_enable_default = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function unity_friend_add_request
refactored with the following changes:
- Move assignments closer to their usage (
move-assign
) - Use x is None rather than x == None (
none-compare
)
if fake_plugin_event.data.host_id != None: | ||
tmp_hagID = '%s|%s' % (str(plugin_event.data.host_id), str(plugin_event.data.group_id)) | ||
else: | ||
if fake_plugin_event.data.host_id is None: | ||
tmp_hagID = str(plugin_event.data.group_id) | ||
else: | ||
tmp_hagID = f'{str(plugin_event.data.host_id)}|{str(plugin_event.data.group_id)}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function unity_group_member_increase
refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches
) - Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring
) - Use x is None rather than x == None (
none-compare
)
releaseDir(dataDirRoot_this + '/unity') | ||
releaseDir(dataDirRoot_this + '/unity/extend') | ||
releaseDir(dataDirRoot_this + '/unity/extend/template') | ||
dataDir = dataDirRoot_this + '/unity/extend/template' | ||
releaseDir(f'{dataDirRoot_this}/unity') | ||
releaseDir(f'{dataDirRoot_this}/unity/extend') | ||
releaseDir(f'{dataDirRoot_this}/unity/extend/template') | ||
dataDir = f'{dataDirRoot_this}/unity/extend/template' | ||
dataPathList = os.listdir(dataDir) | ||
for dataName in dataPathList: | ||
dataPath = dataDir + '/' + dataName | ||
dataPath = f'{dataDir}/{dataName}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function dataPcCardTemplateDefaultInit
refactored with the following changes:
- Use f-string instead of string concatenation [×6] (
use-fstring-for-concatenation
) - Hoist repeated code outside conditional statement (
hoist-statement-from-if
) - Remove redundant conditional (
remove-redundant-if
)
This removes the following comments ( why? ):
# 此处等待后续实现特异化的补丁逻辑
for dictPcCardData_hostkey_this in dictPcCardData[dictPcCardData_this]: | ||
for _ in dictPcCardData[dictPcCardData_this]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function dataPcCardTotalCount
refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore
)
Branch
main
refactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
main
branch, then run:Help us improve this pull request!