fix: route LEPUS global events to GlobalEventEmitter#193
Merged
Conversation
|
@KealanAU is attempting to deploy a commit to the huxpro's projects Team on Vercel. A member of the Team first needs to authorize it. |
53dfb79 to
2fb80c6
Compare
2fb80c6 to
e8b1daf
Compare
Contributor
Author
CleanShot.2026-06-17.at.21.29.21.mp4 |
Huxpro
approved these changes
Jun 27, 2026
Huxpro
left a comment
Owner
There was a problem hiding this comment.
Looks good to me.
One follow-up I'd still like to see is a regression test that explicitly proves the previous tt.OnLifecycleEvent handler is preserved when vue-lynx installs its wrapper, since keeping that compatibility path intact is part of the behavior change here.
Contributor
Author
|
Added a regression test: it installs the wrapper over an existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globalEventFromLepuslifecycle events (e.g.keyboardstatuschanged) never reached the background thread. This routes them intoGlobalEventEmitter.tt.OnLifecycleEventto forward LEPUS lifecycle events toGlobalEventEmitter, preserving any existing handler.useGlobalEvent()composable with automatic scope cleanup (onScopeDispose).useGlobalEventfrom the runtime entry; adds a regression test + patch changeset.Verification
pnpm test; biome clean on touched files.keyboardstatuschangedreachesuseGlobalEvent('keyboardstatuschanged', ...).