fix: FIT-1120: label-stream cypress test failing consistently #8981
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground canceled.
|
nass600
reviewed
Dec 15, 2025
| # 1. not_solved_tasks excludes completed tasks but not locked tasks | ||
| # 2. .first() would keep returning the locked task | ||
| # 3. The user would be stuck on the same task unable to progress | ||
| locked_task = Task.get_locked_by(user, tasks=not_solved_tasks) |
Contributor
There was a problem hiding this comment.
Seems like a fix for the tests but I wonder how this will affect production logic
Contributor
Author
There was a problem hiding this comment.
valid concern - i'd much rather a frontend solution - but this seems to be the only consistent solution
Contributor
Author
|
closing this PR - addressing issue by cleaning up the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an important fix to the task navigation logic in the data manager queue of the labeling workflow. The change ensures that when a user clicks "next" in the label stream, they are not repeatedly assigned the same locked task, allowing for smooth progression through tasks.
Task navigation improvements:
get_next_task(inlabel_studio/projects/functions/next_task.py) to exclude the currently locked task when using the data manager queue, preventing users from getting stuck on the same task when navigating forward.