Skip to content

refactor: FIT-1112: remove fflag_fix_front_leap_218_improve_performance_of_taxonomy_search_short #8972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robot-ci-heartex merged 5 commits into from
Dec 16, 2025
+6 −14
Merged

refactor: FIT-1112: remove fflag_fix_front_leap_218_improve_performance_of_taxonomy_search_short #8972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7630d5
refactor: FIT-1112: remove fflag_fix_front_leap_218_improve_performan…
luarmr Dec 9, 2025
206ca1f
typo
luarmr Dec 10, 2025
e3b4a0b
Clean up defaultSearch on NewTaxonomy
luarmr Dec 11, 2025
9c8d38b
Update web/libs/editor/src/components/NewTaxonomy/NewTaxonomy.tsx
luarmr Dec 12, 2025
fb4aac8
Merge branch 'develop' into 'fb-fit-1112/remove-fflagfixfrontleap218i…
luarmr Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion label_studio/core/feature_flags/stale_feature_flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,4 @@
'fflag_feat_front_leap_1198_unsaved_changes_180724': True,
'fflag_fix_leap_246_multi_object_hotkeys_160124_short': True,
'fflag_fix_leap_466_text_sanitization': True,
'fflag_fix_front_leap_218_improve_performance_of_taxonomy_search_short': True,
}
1 change: 0 additions & 1 deletion web/libs/editor/src/components/Comments/Comment/CommentForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ export const CommentForm: FC<CommentFormProps> = observer(({ commentStore, annot
items={classificationsItems}
onChange={taxonomyOnChange}
options={COMMENT_TAXONOMY_OPTIONS}
defaultSearch={false}
/>
</div>
<CommentFormButtons region={region} linking={linking} onLinkTo={linkToHandler} />
Expand Down
1 change: 0 additions & 1 deletion web/libs/editor/src/components/Comments/Comment/CommentItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ export const CommentItem: FC<CommentItemProps> = observer(
items={classificationsItems}
onChange={taxonomyOnChange}
options={COMMENT_TAXONOMY_OPTIONS}
defaultSearch={false}
/>
</div>
)}
Expand Down
12 changes: 5 additions & 7 deletions web/libs/editor/src/components/NewTaxonomy/NewTaxonomy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ type TaxonomyProps = {
onDeleteLabel?: onDeleteLabelCallback;
options: TaxonomyOptions;
isEditable?: boolean;
defaultSearch?: boolean;
};

type TaxonomyExtendedOptions = TaxonomyOptions & {
Expand Down Expand Up @@ -107,7 +106,6 @@ const NewTaxonomy = ({
selected,
onChange,
onLoadData,
defaultSearch = true,
// @todo implement user labels
// onAddLabel,
// onDeleteLabel,
Expand Down Expand Up @@ -146,7 +144,7 @@ const NewTaxonomy = ({
(origin: ReactNode) => {
return (
<>
{!defaultSearch && <TaxonomySearch ref={refInput} treeData={treeData} onChange={handleSearch} />}
<TaxonomySearch ref={refInput} treeData={treeData} onChange={handleSearch} />
{origin}
</>
);
Expand All @@ -171,7 +169,7 @@ const NewTaxonomy = ({

return (
<TreeSelect
treeData={defaultSearch ? treeData : filteredTreeData}
treeData={filteredTreeData}
value={displayed}
labelInValue={true}
onChange={(items) =>
Expand All @@ -182,11 +180,11 @@ const NewTaxonomy = ({
}
loadData={loadData}
treeCheckable
showSearch={defaultSearch}
showArrow={!defaultSearch}
showSearch={false}
showArrow
dropdownRender={renderDropdown}
onDropdownVisibleChange={handleDropdownChange}
treeExpandedKeys={!defaultSearch ? expandedKeys : undefined}
treeExpandedKeys={expandedKeys}
onTreeExpand={(expandedKeys: React.Key[]) => {
setExpandedKeys(expandedKeys);
}}
Expand Down
3 changes: 1 addition & 2 deletions web/libs/editor/src/tags/control/Taxonomy/Taxonomy.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import SelectedChoiceMixin from "../../../mixins/SelectedChoiceMixin";
import { SharedStoreMixin } from "../../../mixins/SharedChoiceStore/mixin";
import VisibilityMixin from "../../../mixins/Visibility";
import { parseValue } from "../../../utils/data";
import { FF_LEAP_218, FF_LSDV_4583, FF_TAXONOMY_ASYNC, FF_TAXONOMY_LABELING, isFF } from "../../../utils/feature-flags";
import { FF_LSDV_4583, FF_TAXONOMY_ASYNC, FF_TAXONOMY_LABELING, isFF } from "../../../utils/feature-flags";
import ControlBase from "../Base";
import ClassificationBase from "../ClassificationBase";

Expand Down Expand Up @@ -625,7 +625,6 @@ const HtxTaxonomy = observer(({ item }) => {
onAddLabel={item.userLabels && item.onAddLabel}
onDeleteLabel={item.userLabels && item.onDeleteLabel}
options={options}
defaultSearch={!isFF(FF_LEAP_218)}
isEditable={!item.isReadOnly()}
/>
) : (
Expand Down
2 changes: 0 additions & 2 deletions web/libs/editor/src/utils/feature-flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,6 @@ export const FF_LSDV_4998 = "fflag_fix_front_lsdv_4998_missed_dynamic_children_0
*/
export const FF_TAXONOMY_ASYNC = "fflag_feat_front_lsdv_5451_async_taxonomy_110823_short";

export const FF_LEAP_218 = "fflag_fix_front_leap_218_improve_performance_of_taxonomy_search_short";

/**
* Allow to label NER directly with Taxonomy instead of Labels
* @link https://app.launchdarkly.com/default/production/features/fflag_feat_front_lsdv_5452_taxonomy_labeling_110823_short
Expand Down
Loading