Skip to content

Conversation

@yyassi-heartex
Copy link
Contributor

This pull request enhances the Select component in the UI library by adding support for onOpen and onClose callback props. These callbacks allow parent components to respond when the select dropdown is opened or closed, improving integration with other UI elements and application logic.

New event callback support:

  • Added onOpen and onClose optional callback props to the SelectProps type in select/types.ts, enabling consumers to react to dropdown open/close events.
  • Updated the Select component's signature to accept the new onOpen and onClose props.

Event handling logic improvements:

  • Modified the dropdown open/close logic to invoke onOpen when the dropdown is opened and onClose when it is closed, both when triggered via the popover and when selecting an item (for single-select mode). [1] [2]

@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit a22f126
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68ffb8a5ca082a0009e369ba
😎 Deploy Preview https://deploy-preview-8686--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit a22f126
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68ffb8a50b820d00080d69b6

@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit a22f126
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68ffb8a53c81f00008224c76
😎 Deploy Preview https://deploy-preview-8686--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the fix label Oct 22, 2025
@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit a22f126
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68ffb8a52dce07000891265e

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 8.34%. Comparing base (d3fd5f2) to head (a22f126).

❗ There is a different number of reports uploaded between BASE (d3fd5f2) and HEAD (a22f126). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (d3fd5f2) HEAD (a22f126)
pytests 1 0
lsf-integration 1 0
lsf-e2e 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #8686       +/-   ##
===========================================
- Coverage    67.07%   8.34%   -58.73%     
===========================================
  Files          790     478      -312     
  Lines        60675   33264    -27411     
  Branches     10310    9034     -1276     
===========================================
- Hits         40697    2777    -37920     
- Misses       19975   30484    +10509     
  Partials         3       3               
Flag Coverage Δ
lsf-e2e ?
lsf-integration ?
lsf-unit 8.34% <ø> (ø)
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yyassi-heartex yyassi-heartex requested a review from a team October 22, 2025 18:09
@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Oct 23, 2025

/git merge

Workflow run
Successfully merged: 67 files changed, 1193 insertions(+), 1010 deletions(-)

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Oct 26, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/ui/src/assets/icons/webhook.svg

@robot-ci-heartex robot-ci-heartex merged commit 1fd2102 into develop Oct 27, 2025
45 of 46 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-831/member-select branch October 27, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants