-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix: DIA-1435: [FE, cust-Comet] Some errors on Prompt task list are not displayed gracefully on UI #7444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: DIA-1435: [FE, cust-Comet] Some errors on Prompt task list are not displayed gracefully on UI #7444
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0ec6166
Add max-width to the tooltip
nick-skriabin 2b17a49
Allow setting different width via `className`
nick-skriabin 0884c4f
Sync Follow Merge dependencies
MihajloHoma b65d3ca
Merge branch 'develop' into 'fb-dia-1435/error-display'
MihajloHoma 66528ef
Update text wrapping
nick-skriabin 1d9230f
Sync Follow Merge dependencies
MihajloHoma 014b4d7
Merge branch 'develop' into 'fb-dia-1435/error-display'
MihajloHoma c4b28f7
Fix long text display
nick-skriabin 5200994
Add interactive example
nick-skriabin f32670f
Sync Follow Merge dependencies
AndrejOros 8f8361e
Merge branch 'develop' into 'fb-dia-1435/error-display'
AndrejOros e9d364f
Add button states
nick-skriabin c8b2a2f
Add button type to tooltip example
nick-skriabin b2b9a7f
Fix text wrapping
nick-skriabin 56a7055
Fix overflow
nick-skriabin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
import type { Meta, StoryObj } from "@storybook/react"; | ||
import { Tooltip } from "./Tooltip"; | ||
import { Button } from "../button/button"; | ||
|
||
const meta: Meta<typeof Tooltip> = { | ||
component: Tooltip, | ||
title: "UI/Tooltip", | ||
tags: ["autodocs"], | ||
argTypes: { | ||
disabled: { control: "boolean" }, | ||
}, | ||
}; | ||
|
||
export default meta; | ||
type Story = StoryObj<typeof Tooltip>; | ||
|
||
export const Primary: Story = { | ||
render: ({ children, ...props }) => { | ||
return ( | ||
<div className="flex items-center gap-tight"> | ||
<Tooltip {...props} title="Example of a tooltip"> | ||
<Button>hover over me</Button> | ||
</Tooltip> | ||
</div> | ||
); | ||
}, | ||
}; | ||
|
||
export const WithLongText: Story = { | ||
render: ({ children, ...props }) => { | ||
return ( | ||
<div className="flex items-center gap-tight"> | ||
<Tooltip {...props} title="This is a tooltip with a very looooong long long text that goes past the size."> | ||
<Button>hover over me</Button> | ||
</Tooltip> | ||
</div> | ||
); | ||
}, | ||
}; | ||
|
||
export const WithLongTextString: Story = { | ||
render: ({ children, ...props }) => { | ||
return ( | ||
<div className="flex items-center gap-tight"> | ||
<Tooltip {...props} title="Thisisatooltipwithaverylooooonglonglongtextthatgoespastthesize."> | ||
<Button>hover over me</Button> | ||
</Tooltip> | ||
</div> | ||
); | ||
}, | ||
}; | ||
|
||
export const Interactive: Story = { | ||
render: ({ children, ...props }) => { | ||
return ( | ||
<div className="flex items-center gap-tight"> | ||
<Tooltip | ||
{...props} | ||
title={ | ||
<div> | ||
<button type="button" onClick={() => alert("hello there")}> | ||
click me | ||
</button> | ||
</div> | ||
} | ||
interactive | ||
> | ||
<Button>hover over me</Button> | ||
</Tooltip> | ||
</div> | ||
); | ||
}, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.