Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OPTIC-1553: Add URL-based region visibility, hiding all but the specified region on load #6880

Merged
merged 16 commits into from
Feb 13, 2025

Conversation

ddishi
Copy link
Contributor

@ddishi ddishi commented Jan 9, 2025

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Couldn't provide a URL to a specific region while maintaining context.

What does this fix?

(if this is a bug fix)

What is the new behavior?

The ability to read URL parameters in order open the task\annotation with only the specified region presented while all other regions are hidden.
image

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

fflag_feat_front_optic_1553_url_based_region_visibility_short

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Copy link

netlify bot commented Jan 9, 2025

👷 Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4c4c486

Copy link

netlify bot commented Jan 9, 2025

👷 Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4c4c486

@github-actions github-actions bot added the feat label Jan 9, 2025
@ddishi
Copy link
Contributor Author

ddishi commented Jan 20, 2025

Hi @makseq,
Just following up as you suggested in the Slack channel. Could you please bump this PR to the relevant team?
Also, I ran into a merge conflict regarding the proxy config, where the version in main didn’t seem to work for me. Please see #6567, Any guidance there would be great.

Thanks! 🙏

@makseq makseq changed the title feat: DEV: Add URL-based region visibility, hiding all but the specified region on load feat: OPTIC-1553: Add URL-based region visibility, hiding all but the specified region on load Jan 22, 2025
@makseq
Copy link
Member

makseq commented Jan 22, 2025

@ddishi could you please rename your feature flag to this one:
fflag_feat_front_optic_1553_url_based_region_visibility_short
?

@bmartel
Copy link
Contributor

bmartel commented Feb 3, 2025

@ddishi Would you be able to add some tests for this change? Test case(s) for this can be added here:

@bmartel
Copy link
Contributor

bmartel commented Feb 5, 2025

Thanks a bunch @ddishi 🙏

@ddishi ddishi force-pushed the fb/focus-on-region-via-url branch from a5df055 to e458602 Compare February 6, 2025 09:16
@bmartel bmartel enabled auto-merge (squash) February 13, 2025 15:39
@bmartel bmartel self-assigned this Feb 13, 2025
@bmartel bmartel merged commit b02dfd4 into HumanSignal:develop Feb 13, 2025
25 of 26 checks passed
@bmartel
Copy link
Contributor

bmartel commented Feb 13, 2025

@ddishi This change was reviewed internally and accepted and is now merged back into the mainline branch! Just wanted to thank you on behalf of the Label Studio team for your contribution 🙏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants