-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OPTIC-1553: Add URL-based region visibility, hiding all but the specified region on load #6880
feat: OPTIC-1553: Add URL-based region visibility, hiding all but the specified region on load #6880
Conversation
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
@ddishi could you please rename your feature flag to this one: |
@ddishi Would you be able to add some tests for this change? Test case(s) for this can be added here: label-studio/web/libs/editor/tests/integration/e2e/outliner/hide-all.cy.ts Lines 46 to 47 in 2660ec9
|
Thanks a bunch @ddishi 🙏 |
a5df055
to
e458602
Compare
…s visible on navigation
@ddishi This change was reviewed internally and accepted and is now merged back into the mainline branch! Just wanted to thank you on behalf of the Label Studio team for your contribution 🙏. |
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
Couldn't provide a URL to a specific region while maintaining context.
What does this fix?
(if this is a bug fix)
What is the new behavior?
The ability to read URL parameters in order open the task\annotation with only the specified region presented while all other regions are hidden.
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
fflag_feat_front_optic_1553_url_based_region_visibility_short
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)