-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: OPTIC-1490: Safely reference content_type of the response so it does not error #6856
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6856 +/- ##
========================================
Coverage 76.79% 76.79%
========================================
Files 171 171
Lines 14030 14030
========================================
+ Hits 10774 10775 +1
+ Misses 3256 3255 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Max Tkachenko <[email protected]>
Co-authored-by: Marcel Canu <[email protected]>
Co-authored-by: Marcel Canu <[email protected]>
Co-authored-by: Marcel Canu <[email protected]>
Co-authored-by: Marcel Canu <[email protected]>
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
There will be cases where the response has no content_type, which is the case of NotFound response objects. This just makes sure it is present before reading it.
Which logical domain(s) does this change affect?
ContextLog