Merge pull request #92 from HubSpot/js-configurable-ssl-protocols

allow ssl protocols to be configurable per imap connection
HubSpot · Jan 28, 2025 · e078517 · e078517
2 parents a88c08e + 931f48a
commit e078517
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/main/java/com/hubspot/imap/ImapClientConfigurationIF.java b/src/main/java/com/hubspot/imap/ImapClientConfigurationIF.java
@@ -7,6 +7,7 @@
 import com.hubspot.imap.utils.ConfigDefaults;
 import java.util.List;
 import java.util.Optional;
+import java.util.Set;
 import javax.net.ssl.TrustManagerFactory;
 import org.immutables.value.Value.Default;
 import org.immutables.value.Value.Derived;
@@ -36,6 +37,11 @@ default boolean useSsl() {
     return true;
   }
 
+  @Default
+  default Set<String> sslProtocols() {
+    return Set.of();
+  }
+
   @Default
   default int noopKeepAliveIntervalSec() {
     return -1;

diff --git a/src/main/java/com/hubspot/imap/ImapClientFactory.java b/src/main/java/com/hubspot/imap/ImapClientFactory.java
@@ -132,10 +132,15 @@ private SslContext getSslContext(ImapClientConfiguration clientConfiguration) {
       return sslContext;
     }
     try {
-      return SslContextBuilder
+      SslContextBuilder sslContextBuilder = SslContextBuilder
         .forClient()
-        .trustManager(clientConfiguration.trustManagerFactory().get())
-        .build();
+        .trustManager(clientConfiguration.trustManagerFactory().get());
+
+      if (!clientConfiguration.sslProtocols().isEmpty()) {
+        sslContextBuilder.protocols(clientConfiguration.sslProtocols());
+      }
+
+      return sslContextBuilder.build();
     } catch (SSLException e) {
       throw new RuntimeException(e);
     }