Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS 1.3 support #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

DengYiping
Copy link

@DengYiping DengYiping commented May 19, 2023

@DengYiping
Copy link
Author

We can also add protocols as a config in our own SslConfig, but I think defaulting with TLSv1.2 and TLSv1.3 should be sufficient for most cases.

@jhaber
Copy link
Member

jhaber commented May 19, 2023

Do you know what protocols were being inferred before and how Netty was inferring them?

Specifically I'm wondering about:

  1. Instead of doing this manually, is there a JVM flag we can set that enables TLSv1.3? (and hopefully that Netty would also respect)
  2. Are we removing any protocols that were previously enabled? Because people use Horizon to hit arbitrary sites on the internet, which might still be using older versions or other protocols

@DengYiping
Copy link
Author

Instead of doing this manually, is there a JVM flag we can set that enables TLSv1.3? (and hopefully that Netty would also respect)

This is a clear no. Lower version of Netty has TLSv1.3 set as disabled by default, only Netty 4.1.52 started to default it as enabled.

Are we removing any protocols that were previously enabled? Because people use Horizon to hit arbitrary sites on the internet, which might still be using older versions or other protocols.

This is a great point. I will add all TLS version there to be backward compatible, but I think we should also put in some efforts inside HubSpot to investigate how is still using TLS 1.0 and TLS 1.1 because those protocols are less secure and it is deprecated since 2021.

@kenbreeman
Copy link
Member

We officially sunset TLS 1.0 and 1.1 for incoming connections back in March 2021:
https://developers.hubspot.com/changelog/tls-1-and-1-11-sunset

Outgoing connections we've continued to support falling back to older protocols if the server doesn't support 1.2 but we should eventually sunset that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants