Added support for setting the read timeout in http config #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying apache and ning clients support socket/read timeout. With the current implementation this is hardcoded to the request timeout.
jhaber
reviewed
Apr 4, 2018
| @@ -98,15 +100,15 @@ private RequestConfig createRequestConfig(HttpConfig config) { | |||
| return RequestConfig.custom() | |||
| .setConnectionRequestTimeout(config.getConnectTimeoutMillis()) | |||
| .setConnectTimeout(config.getConnectTimeoutMillis()) | |||
| .setSocketTimeout(config.getRequestTimeoutMillis()) | |||
| .setSocketTimeout(config.getReadTimeoutMillis()) | |||
There was a problem hiding this comment.
Won't this break anyone who was setting requestTimeoutMillis?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying apache and ning clients support socket/read timeout. With the current implementation this is hardcoded to the request timeout.
/cc @jhaber