[mod/#34]: 홈 이미지 수정

[vvan2]

ISSUE

• closed [mod] UI 디테일 잡기 #34

❗ WORK DESCRIPTION

• 홈 이미지 수정했습니다
• 온보딩 수정 맡아주셔서 감사합니두

📸 SCREENSHOT

📢 TO REVIEWERS

• 리뷰어에게 전달해야 하는 말

Summary by CodeRabbit

• New Features
  • Home carousel now displays an expanded collection of updated images sourced from the Hansung site, replacing previous placeholder content with enhanced visual assets for improved user experience.

[coderabbitai]

Walkthrough

The HomeScreen carousel component's pagerImages data list was updated from three placeholder entries to five explicit image URLs sourced from the Hansung website. The carousel now displays five images instead of three, with no modifications to logic or control flow.

Changes

Cohort / File(s)	Summary
HomeScreen Carousel Images app/src/main/java/com/hsLink/hslink/presentation/home/screen/HomeScreen.kt	Updated HomeCarousel pagerImages list: replaced 3 placeholder image entries with 5 explicit Hansung site image URLs

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Verify all five image URLs are valid and correctly formatted
• Confirm the URLs point to the intended Hansung website images
• Validate that carousel rendering handles the increased image count without layout issues

Possibly related PRs

• PR #13: Implements the new HomeScreen and HomeCarousel components, which this PR now populates with real image data from Hansung

Suggested reviewers

• dmp100

Poem

🐰✨ Five images bloom where three once stood,
Hansung's carousel looking crisp and good!
URLs gleaming, bright and true,
The carousel dances—fresh and new! 🎠

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title '[mod/#34]: 홈 이미지 수정' clearly describes the main change—updating home screen images for issue #34, directly matching the changeset content.
Description check	✅ Passed	The description follows the template structure with ISSUE, WORK DESCRIPTION, and SCREENSHOT sections completed; however, the BEFORE/AFTER comparison is missing and the TO REVIEWERS section is left as a placeholder.
Linked Issues check	✅ Passed	The PR updates home carousel images (5 explicit URLs replacing 3 placeholders) which aligns with tidying up UI details [#34], though the to-do list in the issue lacks specific tasks.
Out of Scope Changes check	✅ Passed	All changes are confined to HomeScreen carousel image data; the update is directly within the scope of UI detail refinement outlined in issue #34.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch mod/#34-ui-detail

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 788788d and 21afda2.

📒 Files selected for processing (1)

• app/src/main/java/com/hsLink/hslink/presentation/home/screen/HomeScreen.kt (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build-and-test

🔇 Additional comments (1)

app/src/main/java/com/hsLink/hslink/presentation/home/screen/HomeScreen.kt (1)

124-130: Verify URL accessibility and consider externalizing image sources.

The carousel now displays 5 hardcoded image URLs from the Hansung University website. While this achieves the immediate goal of updating the home images, consider the following:

1. Reliability: The app directly depends on www.hansung.ac.kr availability. If the university updates or removes these images, the carousel will break.

2. Maintainability: Hardcoded URLs require app redeployment to update. Consider extracting these to a companion object constant or loading from a backend API for easier updates.

Run the following script to verify all image URLs are currently accessible:

Suggested refactor (extract to constants):

companion object {
    private val CAROUSEL_IMAGE_URLS = listOf(
        "https://www.hansung.ac.kr/sites/hansung/images/main/slide_main/24-003.jpg",
        "https://www.hansung.ac.kr/sites/hansung/images/main/slide_main/24-%EC%A0%84%EA%B5%AC.jpg",
        "https://www.hansung.ac.kr/sites/hansung/images/main/slide_main/%EC%84%B1%EA%B9%9403.jpg",
        "https://www.hansung.ac.kr/sites/hansung/images/main/slide_main/%EC%84%B1%EA%B9%9401.jpg",
        "https://www.hansung.ac.kr/sites/hansung/images/main/slide_main/24-001.jpg"
    )
}

Then use it in the carousel:

HomeCarousel(
    pagerImages = CAROUSEL_IMAGE_URLS,
)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}