[feat/#22] 게시물 작성 API 연동 #23
Conversation
WalkthroughThis pull request implements community post creation functionality by adding a complete data pipeline from network API through repositories to the presentation layer, reorganizes post-related repositories into a home subdirectory, updates dependency injection configurations, and enhances the UI with Korean labels, updated bottom navigation icons, and dialog styling refinements. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant Screen as CommunityWritingScreen
participant VM as CommunityViewModel
participant Repo as CommunityRepositoryImpl
participant DS as CommunityPostDataSourceImpl
participant Service as CommunityPostService
participant API as API Server
User->>Screen: Enter post details (type, title, body)
User->>Screen: Click create button
Screen->>VM: createPost(postType, title, body)
activate VM
VM->>VM: Build PostRequestDto
VM->>Repo: createCommunityPost(request)
activate Repo
Repo->>DS: createCommunityPost(request)
activate DS
DS->>Service: postCommunity(token, request)
activate Service
Service->>API: POST /posts
activate API
API-->>Service: BaseResponse<CommunityPostResponseDto>
deactivate API
Service-->>DS: return response
deactivate Service
DS-->>Repo: return BaseResponse
deactivate DS
alt Success
Repo->>Repo: runCatching success path
Repo-->>VM: Result.success(CommunityPostResponseDto)
else Failure
Repo->>Repo: runCatching failure path
Repo-->>VM: Result.failure(exception)
end
deactivate Repo
VM->>VM: Update _state with result
deactivate VM
VM-->>Screen: Emit state update
Screen->>Screen: Recompose UI with new state
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Areas requiring extra attention:
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
app/src/main/java/com/hsLink/hslink/presentation/main/component/MainBottomBar.kt (1)
50-78: Fix the layout structure for HorizontalDivider.The
HorizontalDividerandRoware both direct children of theSurface, butSurfacecan only have a single child composable. This will cause a compilation error. Wrap them in aColumnto properly stack the divider above the navigation items.Apply this diff:
Surface( color = Color.White, ) { + Column { - HorizontalDivider( - modifier = Modifier.fillMaxWidth(), - thickness = 1.dp, - color = HsLinkTheme.colors.Grey100, - ) - Row( - modifier = modifier - .fillMaxWidth() - .navigationBarsPadding() - .padding(horizontal = 5.dp) - .selectableGroup(), - horizontalArrangement = Arrangement.SpaceBetween, - verticalAlignment = Alignment.CenterVertically, - ) { - tabs.forEach { tab -> - MainNavigationBarItem( - selected = tab == currentTab, - tab = tab, - onClick = { onTabSelected(tab) }, - modifier = Modifier - .weight(1f) - .padding(vertical = 12.dp), - ) + HorizontalDivider( + modifier = Modifier.fillMaxWidth(), + thickness = 1.dp, + color = HsLinkTheme.colors.Grey100, + ) + Row( + modifier = modifier + .fillMaxWidth() + .navigationBarsPadding() + .padding(horizontal = 5.dp) + .selectableGroup(), + horizontalArrangement = Arrangement.SpaceBetween, + verticalAlignment = Alignment.CenterVertically, + ) { + tabs.forEach { tab -> + MainNavigationBarItem( + selected = tab == currentTab, + tab = tab, + onClick = { onTabSelected(tab) }, + modifier = Modifier + .weight(1f) + .padding(vertical = 12.dp), + ) + } } } }app/src/main/java/com/hsLink/hslink/presentation/community/screen/write/CommunityWritingScreen.kt (1)
257-271: Missing ViewModel integration for post creation in upload dialog.The upload dialog's
onConfirmhandler (lines 265-267) only dismisses the dialog and navigates away, without creating the post. The screen requires:
- Inject
CommunityViewModelvia Hilt- Call
viewModel.createPost(selectedBoardType.apiValue, title, content)before navigating- Handle loading/success/error states from the ViewModel's state
Currently, users confirm upload but no post is created—critical functionality gap for the API integration feature.
🧹 Nitpick comments (5)
app/src/main/java/com/hsLink/hslink/data/repositoryimpl/home/PostRepositoryImpl.kt (1)
25-29: Fix variable name typo for consistency.There's a typo in the variable name:
responeshould beresponseto match the naming convention used ingetPopularPost()(line 15).Apply this diff to fix the typo:
- val respone = postDataSourceImpl.getPromotionPost() - if (respone.isSuccess) { - respone.result.posts.map { it.toEntity() } + val response = postDataSourceImpl.getPromotionPost() + if (response.isSuccess) { + response.result.posts.map { it.toEntity() } } else { - throw Exception(respone.message) + throw Exception(response.message) }app/src/main/java/com/hsLink/hslink/presentation/main/component/MainBottomBar.kt (1)
50-52: Consider using a theme color for the Surface background.The
Surfaceuses a hardcodedColor.White. For better theme consistency and support for dark mode or alternative themes, consider using a theme color likeHsLinkTheme.colors.BackgroundorHsLinkTheme.colors.Surface.app/src/main/java/com/hsLink/hslink/presentation/community/component/write/CommunityWriteButton.kt (1)
51-51: Verify the large horizontal padding value.The horizontal padding of 100.dp (200.dp total) is quite substantial and may constrain the button content on smaller screens or narrower layouts. Please confirm this value aligns with the design specifications.
app/src/main/java/com/hsLink/hslink/data/di/DataSourceModule.kt (1)
20-23: Rename method to reflect remote data source.The method name
bindsPostLocalDataSourceis misleading sinceCommunityPostDataSourceImpluses a network service (CommunityPostService). Consider renaming tobindsCommunityPostRemoteDataSourceor simplybindsCommunityPostDataSourcefor consistency.Also note: the existing method at line 16 has a typo (
bindePostRemoteDataSourceshould bebindsPostRemoteDataSource).Apply this diff:
@Binds - abstract fun bindsPostLocalDataSource( + abstract fun bindsCommunityPostDataSource( communityPostDataSourceImpl: CommunityPostDataSourceImpl, ): CommunityPostDataSourceapp/src/main/java/com/hsLink/hslink/data/repositoryimpl/CommunityRepositoryImpl.kt (1)
3-11: Inject the data source interface, not the implementationLines 9-10 bind directly to
CommunityPostDataSourceImpl, which couples the repository to a concrete class and undermines the interface we just introduced. Switch the dependency toCommunityPostDataSourceso you can mock it in tests and keep the DI graph flexible.-import com.hsLink.hslink.data.remote.datasourceimpl.CommunityPostDataSourceImpl +import com.hsLink.hslink.data.remote.datasource.CommunityPostDataSource @@ -class CommunityRepositoryImpl @Inject constructor( - private val communityPostDataSourceImpl: CommunityPostDataSourceImpl, +class CommunityRepositoryImpl @Inject constructor( + private val communityPostDataSource: CommunityPostDataSource, ) : CommunityRepository {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (38)
app/src/main/java/com/hsLink/hslink/core/designsystem/component/HsLinkDialog.kt(2 hunks)app/src/main/java/com/hsLink/hslink/data/DummyDto.kt(0 hunks)app/src/main/java/com/hsLink/hslink/data/di/DataSourceModule.kt(2 hunks)app/src/main/java/com/hsLink/hslink/data/di/NetworkModule.kt(2 hunks)app/src/main/java/com/hsLink/hslink/data/di/RepositoryModule.kt(2 hunks)app/src/main/java/com/hsLink/hslink/data/dto/DummyDto.kt(1 hunks)app/src/main/java/com/hsLink/hslink/data/dto/request/PostRequestDto.kt(1 hunks)app/src/main/java/com/hsLink/hslink/data/dto/response/CommunityPostResponseDto.kt(1 hunks)app/src/main/java/com/hsLink/hslink/data/dto/response/PostResponseDto.kt(1 hunks)app/src/main/java/com/hsLink/hslink/data/remote/datasource/CommunityPostDataSource.kt(1 hunks)app/src/main/java/com/hsLink/hslink/data/remote/datasourceimpl/CommunityPostDataSourceImpl.kt(1 hunks)app/src/main/java/com/hsLink/hslink/data/repositoryimpl/CommunityRepositoryImpl.kt(1 hunks)app/src/main/java/com/hsLink/hslink/data/repositoryimpl/home/PostRepositoryImpl.kt(1 hunks)app/src/main/java/com/hsLink/hslink/data/service/commuunity/CommunityPostService.kt(1 hunks)app/src/main/java/com/hsLink/hslink/domain/model/community/CommunityPostResponseEntity.kt(1 hunks)app/src/main/java/com/hsLink/hslink/domain/model/home/PostResponseEntity.kt(1 hunks)app/src/main/java/com/hsLink/hslink/domain/repository/PostRepository.kt(0 hunks)app/src/main/java/com/hsLink/hslink/domain/repository/community/CommunityRepository.kt(1 hunks)app/src/main/java/com/hsLink/hslink/domain/repository/home/PostRepository.kt(1 hunks)app/src/main/java/com/hsLink/hslink/presentation/community/component/write/BoardSelectionField.kt(1 hunks)app/src/main/java/com/hsLink/hslink/presentation/community/component/write/CommunityWriteButton.kt(1 hunks)app/src/main/java/com/hsLink/hslink/presentation/community/screen/write/CommunityWritingScreen.kt(4 hunks)app/src/main/java/com/hsLink/hslink/presentation/community/state/CommunityContract.kt(1 hunks)app/src/main/java/com/hsLink/hslink/presentation/community/viewmodel/CommunityViewModel.kt(1 hunks)app/src/main/java/com/hsLink/hslink/presentation/home/screen/HomeScreen.kt(1 hunks)app/src/main/java/com/hsLink/hslink/presentation/home/state/HomeContract.kt(1 hunks)app/src/main/java/com/hsLink/hslink/presentation/home/viewmodel/HomeViewModel.kt(1 hunks)app/src/main/java/com/hsLink/hslink/presentation/main/MainTab.kt(1 hunks)app/src/main/java/com/hsLink/hslink/presentation/main/component/MainBottomBar.kt(5 hunks)app/src/main/res/drawable/ic_bottombar_community_off.xml(1 hunks)app/src/main/res/drawable/ic_bottombar_community_on.xml(1 hunks)app/src/main/res/drawable/ic_bottombar_home_off.xml(1 hunks)app/src/main/res/drawable/ic_bottombar_home_on.xml(1 hunks)app/src/main/res/drawable/ic_bottombar_mypage_off.xml(1 hunks)app/src/main/res/drawable/ic_bottombar_mypage_on.xml(1 hunks)app/src/main/res/drawable/ic_bottombar_search_off.xml(1 hunks)app/src/main/res/drawable/ic_bottombar_search_on.xml(1 hunks)app/src/main/res/values/strings.xml(1 hunks)
💤 Files with no reviewable changes (2)
- app/src/main/java/com/hsLink/hslink/domain/repository/PostRepository.kt
- app/src/main/java/com/hsLink/hslink/data/DummyDto.kt
🧰 Additional context used
🪛 detekt (1.23.8)
app/src/main/java/com/hsLink/hslink/data/dto/DummyDto.kt
[warning] 3-4: The class or object DummyDto is empty.
(detekt.empty-blocks.EmptyClassBlock)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-and-test
🔇 Additional comments (28)
app/src/main/java/com/hsLink/hslink/data/repositoryimpl/home/PostRepositoryImpl.kt (1)
1-1: LGTM! Package reorganization looks good.The refactoring to move this repository into the
homesubdirectory aligns with the domain structure reorganization. The package declaration and import paths are correctly updated.Also applies to: 5-7
app/src/main/java/com/hsLink/hslink/core/designsystem/component/HsLinkDialog.kt (1)
71-71: LGTM!The typography change from
btm_Mtobtm_Sconsistently reduces button text size for both dismiss and confirm actions, aligning with the dialog styling refinements noted in the PR.Also applies to: 89-89
app/src/main/res/drawable/ic_bottombar_home_off.xml (1)
1-9: LGTM!The vector drawable follows standard conventions with appropriate dimensions (28dp) and uses the correct off-state color (#3B3C3F) consistent with the bottom navigation icon set.
app/src/main/res/drawable/ic_bottombar_community_off.xml (1)
1-9: LGTM!The community off-state icon follows the same conventions as the other bottom bar icons with consistent sizing and color scheme.
app/src/main/res/drawable/ic_bottombar_search_on.xml (1)
1-9: LGTM!The search on-state icon correctly uses the active color (#0047BB) and maintains consistent dimensions with the rest of the bottom bar icon set.
app/src/main/res/drawable/ic_bottombar_mypage_off.xml (1)
1-9: LGTM!The mypage off-state icon is consistent with the bottom navigation icon set in terms of dimensions and color scheme.
app/src/main/res/drawable/ic_bottombar_home_on.xml (1)
1-9: LGTM!The home on-state icon properly uses the active blue color (#0047BB) and pairs well with the home_off variant to provide clear visual feedback for navigation state.
app/src/main/res/drawable/ic_bottombar_search_off.xml (1)
1-9: LGTM!The search off-state icon completes the search icon pair with appropriate off-state styling, maintaining consistency across the bottom navigation icon set.
app/src/main/java/com/hsLink/hslink/presentation/home/screen/HomeScreen.kt (1)
104-105: LGTM!The addition of 12.dp start padding to the HsLinkTopBar improves alignment and is consistent with the home topbar design updates noted in the PR.
app/src/main/res/drawable/ic_bottombar_community_on.xml (1)
1-9: Looks good.The drawable resource is properly structured and uses the same color as the other on-state icons for consistency.
app/src/main/res/values/strings.xml (1)
4-7: LGTM! Good localization.The Korean labels for bottom navigation items are clear and appropriate for both UI display and accessibility (screen reader) purposes.
app/src/main/java/com/hsLink/hslink/presentation/main/MainTab.kt (1)
21-43: All drawable resources verified as present.All 8 bottom navigation icon drawable resources referenced in the code are present in the codebase at
app/src/main/res/drawable/.app/src/main/java/com/hsLink/hslink/presentation/main/component/MainBottomBar.kt (1)
104-108: No issues found.The typography style
caption_12Normalis properly defined inapp/src/main/java/com/hsLink/hslink/core/designsystem/theme/Type.ktand is consistently used across multiple components in the codebase. The code change is valid.app/src/main/res/drawable/ic_bottombar_mypage_on.xml (1)
8-8: Verified — no changes needed.The hardcoded color
#0047BBcorrectly matchesDeepBlue500from the theme and is consistently applied across all bottom bar selected-state icons. No action required.app/src/main/java/com/hsLink/hslink/presentation/community/component/write/BoardSelectionField.kt (1)
86-86: LGTM!The horizontal padding adjustment improves the visual spacing of the dropdown menu.
app/src/main/java/com/hsLink/hslink/data/remote/datasource/CommunityPostDataSource.kt (1)
7-11: LGTM!The data source interface is clean and follows the repository pattern correctly for the community post creation flow.
app/src/main/java/com/hsLink/hslink/data/service/commuunity/CommunityPostService.kt (1)
11-17: Token handling is incomplete.The service correctly accepts an Authorization token parameter. However, based on the PR objectives, authentication token handling is noted as incomplete and needs to be addressed.
Please ensure:
- Token is properly retrieved from a secure source (e.g., encrypted SharedPreferences, keystore)
- Token refresh logic is implemented if needed
- Proper error handling for authentication failures (401/403 responses)
app/src/main/java/com/hsLink/hslink/data/dto/request/PostRequestDto.kt (1)
6-14: LGTM!The DTO structure is well-defined with appropriate serialization annotations for the post creation request payload.
app/src/main/java/com/hsLink/hslink/data/dto/response/PostResponseDto.kt (1)
3-4: LGTM!The import path updates align with the domain model reorganization into the
homesubdirectory, improving code organization.app/src/main/java/com/hsLink/hslink/domain/model/home/PostResponseEntity.kt (1)
1-1: LGTM!The package reorganization improves code structure by grouping home-related domain models. The removal of the unused
SerialNameimport is also a good cleanup.app/src/main/java/com/hsLink/hslink/presentation/home/viewmodel/HomeViewModel.kt (1)
5-5: LGTM!The import path correctly follows the repository reorganization to the
homesubdirectory.app/src/main/java/com/hsLink/hslink/domain/model/community/CommunityPostResponseEntity.kt (1)
3-5: LGTM!Clean domain entity for the post creation response. The structure is appropriate for the API response mapping flow.
app/src/main/java/com/hsLink/hslink/presentation/community/screen/write/CommunityWritingScreen.kt (1)
22-24: LGTM!The addition of red asterisks to required field labels enhances UX by clearly indicating mandatory inputs. The implementation using
buildAnnotatedStringis clean and consistent across all three fields.Also applies to: 123-128, 151-156, 186-191
app/src/main/java/com/hsLink/hslink/data/di/NetworkModule.kt (1)
68-71: LGTM!The service provider follows the established pattern and is correctly annotated for dependency injection.
app/src/main/java/com/hsLink/hslink/presentation/home/state/HomeContract.kt (1)
4-5: LGTM!The import path updates align with the domain model reorganization, improving code organization by grouping home-related entities under the
homesubpackage.app/src/main/java/com/hsLink/hslink/domain/repository/home/PostRepository.kt (1)
6-9: LGTM!Clean repository interface following Kotlin best practices with suspend functions and
Resultfor error handling. The reorganization into thehomesubpackage improves code organization.app/src/main/java/com/hsLink/hslink/data/di/RepositoryModule.kt (1)
3-3: LGTM!The dependency injection configuration properly wires the new community repository and updates import paths to reflect the reorganized package structure. The binding follows the established pattern.
Also applies to: 5-5, 7-8, 28-31
app/src/main/java/com/hsLink/hslink/presentation/community/viewmodel/CommunityViewModel.kt (1)
15-21: LGTM!The ViewModel structure follows best practices with Hilt dependency injection and StateFlow for state management.
| package com.hsLink.hslink.data.di | ||
|
|
||
| import com.hsLink.hslink.BuildConfig | ||
| import com.hsLink.hslink.data.service.commuunity.CommunityPostService |
There was a problem hiding this comment.
🧩 Analysis chain
Fix package name typo.
The package name contains a typo: commuunity should be community (has three 'u's instead of two). This should be corrected in both the package structure and all import statements.
Verify the extent of this typo across the codebase:
🏁 Script executed:
#!/bin/bash
# Search for the typo in package names and imports
rg -n "commuunity" --type=ktLength of output: 26
🏁 Script executed:
#!/bin/bash
# Search for the typo across all files
rg -n "commuunity"Length of output: 434
🏁 Script executed:
#!/bin/bash
# Also search for correct spelling to understand if it was fixed elsewhere
rg -n "community"Length of output: 11323
Fix package name typo in data service layer.
The package com.hsLink.hslink.data.service.commuunity contains a typo: commuunity should be community (three 'u's instead of two). This typo exists in the package definition and is imported in two locations:
- app/src/main/java/com/hsLink/hslink/data/service/commuunity/CommunityPostService.kt (package declaration)
- app/src/main/java/com/hsLink/hslink/data/remote/datasourceimpl/CommunityPostDataSourceImpl.kt (import)
- app/src/main/java/com/hsLink/hslink/data/di/NetworkModule.kt (import)
Rename the package directory from commuunity to community, update the package declaration, and update both import statements accordingly.
🤖 Prompt for AI Agents
In app/src/main/java/com/hsLink/hslink/data/di/NetworkModule.kt around line 4
and the related files
app/src/main/java/com/hsLink/hslink/data/service/commuunity/CommunityPostService.kt
and
app/src/main/java/com/hsLink/hslink/data/remote/datasourceimpl/CommunityPostDataSourceImpl.kt,
there is a package name typo: "commuunity" should be "community"; rename the
directory commuunity -> community, update the package declaration in
CommunityPostService.kt to use com.hsLink.hslink.data.service.community, and
update import statements in NetworkModule.kt and CommunityPostDataSourceImpl.kt
to import com.hsLink.hslink.data.service.community.CommunityPostService (and any
other occurrences) so all references use the corrected package name.
| class DummyDto { | ||
| } No newline at end of file |
There was a problem hiding this comment.
❓ Verification inconclusive
Remove unused empty class or implement with proper DTO properties.
This empty DummyDto class serves no functional purpose. Given the PR's focus on post creation API integration, consider either:
- Removing this placeholder class if it's unused
- Implementing it with actual data transfer properties if needed
Run the following script to verify whether this class is referenced elsewhere:
🏁 Script executed:
#!/bin/bash
# Description: Check if DummyDto is referenced anywhere in the codebase
# Search for DummyDto usage across the codebase
rg -nP '\bDummyDto\b' -g '!**/DummyDto.kt'Length of output: 0
Remove the unused DummyDto class.
The class is empty and has no references anywhere in the codebase. It appears to be leftover placeholder code that should be deleted.
🧰 Tools
🪛 detekt (1.23.8)
[warning] 3-4: The class or object DummyDto is empty.
(detekt.empty-blocks.EmptyClassBlock)
🤖 Prompt for AI Agents
In app/src/main/java/com/hsLink/hslink/data/dto/DummyDto.kt around lines 3-4,
remove the unused empty DummyDto class file entirely; delete the file and ensure
no imports or references remain elsewhere (run a quick project-wide search to
confirm) and commit the deletion.
| override suspend fun createCommunityPost( | ||
| request : PostRequestDto | ||
| ) : BaseResponse<CommunityPostResponseDto> { | ||
| // TODO: Replace dummy token with real access token | ||
| return communityPostService.postCommunity(token = "", requestBody = request) | ||
| } |
There was a problem hiding this comment.
Pass the real auth token to the API call
Right now Line 17 hardcodes token = "". The backend requires an authenticated request, so every call will come back 401/403 and the feature can never succeed in any real environment. Please retrieve the access token from the token store (or inject a token provider) and send the correctly prefixed value when calling the service.
-class CommunityPostDataSourceImpl @Inject constructor(
- private val communityPostService: CommunityPostService
-) : CommunityPostDataSource {
+class CommunityPostDataSourceImpl @Inject constructor(
+ private val communityPostService: CommunityPostService,
+ private val tokenProvider: TokenProvider,
+) : CommunityPostDataSource {
override suspend fun createCommunityPost(
request : PostRequestDto
) : BaseResponse<CommunityPostResponseDto> {
- // TODO: Replace dummy token with real access token
- return communityPostService.postCommunity(token = "", requestBody = request)
+ val accessToken = tokenProvider.requireAccessToken()
+ return communityPostService.postCommunity(
+ token = "Bearer $accessToken",
+ requestBody = request
+ )
}
}Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In
app/src/main/java/com/hsLink/hslink/data/remote/datasourceimpl/CommunityPostDataSourceImpl.kt
around lines 13 to 18, the API call currently hardcodes token = "" — replace
this with the real access token fetched from your token provider/store and pass
it with the proper Authorization prefix. Inject (or use the existing)
TokenProvider/TokenStore into this data source, call its method to obtain the
access token (await/suspend if required), validate or handle a missing token
(throw or return an appropriate error), and call
communityPostService.postCommunity(token = "Bearer <accessToken>", requestBody =
request). Ensure to propagate errors cleanly if token retrieval fails.
| override suspend fun createCommunityPost(communityRequestDto: PostRequestDto): Result<CommunityPostResponseDto> = runCatching { | ||
| val response = communityPostDataSourceImpl.createCommunityPost(communityRequestDto) | ||
| if (response.isSuccess) { | ||
| response.result | ||
| } else { | ||
| throw Exception(response.message) | ||
| } | ||
| } |
There was a problem hiding this comment.
Map the response to the domain model before returning
Lines 12-16 still hand out CommunityPostResponseDto. Combined with the interface change above, the domain/presentation layers remain coupled to data-layer DTOs, and there’s also no guard if result comes back null. Please keep the mapping in the data layer: check isSuccess, ensure the payload exists, convert it via toEntity(), and return Result<CommunityPostResponseEntity>.
- override suspend fun createCommunityPost(communityRequestDto: PostRequestDto): Result<CommunityPostResponseDto> = runCatching {
- val response = communityPostDataSourceImpl.createCommunityPost(communityRequestDto)
- if (response.isSuccess) {
- response.result
- } else {
- throw Exception(response.message)
- }
- }
+ override suspend fun createCommunityPost(communityRequestDto: PostRequestDto): Result<CommunityPostResponseEntity> =
+ runCatching {
+ val response = communityPostDataSource.createCommunityPost(communityRequestDto)
+ if (!response.isSuccess) {
+ throw IllegalStateException(response.message ?: "Failed to create community post")
+ }
+ val body = response.result ?: throw IllegalStateException("Create community post returned no body")
+ body.toEntity()
+ }Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In
app/src/main/java/com/hsLink/hslink/data/repositoryimpl/CommunityRepositoryImpl.kt
around lines 12 to 19, the method currently returns the DTO directly and doesn't
guard against a null payload; update the implementation so after calling
communityPostDataSourceImpl.createCommunityPost(...) you check
response.isSuccess, ensure response.result is non-null (throw a meaningful
exception if null), map the DTO to the domain entity via toEntity(), and return
Result.success(mappedEntity); if not successful throw or return Result.failure
with the response.message wrapped as an exception — ensure the repository
signature returns Result<CommunityPostResponseEntity>.
| @@ -0,0 +1,17 @@ | |||
| package com.hsLink.hslink.data.service.commuunity | |||
There was a problem hiding this comment.
Fix package name typo.
The package name contains a typo: "commuunity" should be "community" (remove the extra 'u'). This affects the file location and all imports referencing this service.
Apply this fix:
-package com.hsLink.hslink.data.service.commuunity
+package com.hsLink.hslink.data.service.communityNote: You'll also need to move the file from data/service/commuunity/ to data/service/community/ and update all import statements that reference this package.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| package com.hsLink.hslink.data.service.commuunity | |
| package com.hsLink.hslink.data.service.community |
🤖 Prompt for AI Agents
In
app/src/main/java/com/hsLink/hslink/data/service/commuunity/CommunityPostService.kt
around line 1, the package declaration has a typo ("commuunity"); change it to
"community", move the file from data/service/commuunity/ to
data/service/community/, update the package declaration at the top of the file
accordingly, and update every import and any references across the codebase that
point to com.hsLink.hslink.data.service.commuunity to the corrected
com.hsLink.hslink.data.service.community so imports and file paths remain
consistent.
| import com.hsLink.hslink.data.dto.request.PostRequestDto | ||
| import com.hsLink.hslink.data.dto.response.CommunityPostResponseDto | ||
|
|
||
| interface CommunityRepository { | ||
| suspend fun createCommunityPost(communityRequestDto: PostRequestDto): Result<CommunityPostResponseDto> |
There was a problem hiding this comment.
Keep the domain contract free of data-layer DTOs
Line 7 exposes PostRequestDto and CommunityPostResponseDto from the data module directly in the domain interface. That breaks the layering we rely on (domain → data) and forces the rest of the domain/presentation layers to depend on serialization DTOs, making testing harder and risking future regressions whenever the API payload changes. Please keep the contract expressed in domain models (e.g., introduce a CommunityPostRequestEntity and return CommunityPostResponseEntity). That keeps the mapping inside the data layer where it belongs and preserves the intended dependency direction.
-import com.hsLink.hslink.data.dto.request.PostRequestDto
-import com.hsLink.hslink.data.dto.response.CommunityPostResponseDto
+import com.hsLink.hslink.domain.model.community.CommunityPostRequestEntity
+import com.hsLink.hslink.domain.model.community.CommunityPostResponseEntity
@@
-interface CommunityRepository {
- suspend fun createCommunityPost(communityRequestDto: PostRequestDto): Result<CommunityPostResponseDto>
-}
+interface CommunityRepository {
+ suspend fun createCommunityPost(request: CommunityPostRequestEntity): Result<CommunityPostResponseEntity>
+}Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In
app/src/main/java/com/hsLink/hslink/domain/repository/community/CommunityRepository.kt
around lines 3 to 7, the domain interface currently references data-layer DTOs
(PostRequestDto, CommunityPostResponseDto); replace those with domain model
types (e.g., CommunityPostRequestEntity and CommunityPostResponseEntity) so the
domain contract depends only on domain types, not data DTOs. Create the new
entities in the domain module, update this interface signature to use them,
remove imports of data DTOs from this file, and then implement mapping inside
the data layer (map domain entities to/from
PostRequestDto/CommunityPostResponseDto) so only the data module knows about
DTOs while keeping the Result return type unchanged.
| fun createPost(postType: String, title: String, body: String) { | ||
| viewModelScope.launch { | ||
| val request = PostRequestDto( | ||
| postType = postType, | ||
| title = title, | ||
| body = body | ||
| ) | ||
| repository.createCommunityPost(request) | ||
| .onSuccess { | ||
| // Handle success | ||
| } | ||
| .onFailure { | ||
| // Handle failure | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Implement state management for post creation.
The createPost function has placeholder handlers that don't update UI state, resulting in no user feedback. Essential improvements needed:
- Loading state: Set
_state.value = _state.value.copy(isLoading = true)before the call - Success handling: Update state, possibly emit a success event, enable navigation
- Error handling: Update
_state.value = _state.value.copy(error = it.message) - Final cleanup: Reset loading state in both paths
Without these updates, users receive no feedback about post creation success or failure.
Note: Token authentication is acknowledged as missing per PR objectives.
Example implementation:
fun createPost(postType: String, title: String, body: String) {
viewModelScope.launch {
+ _state.value = _state.value.copy(isLoading = true)
val request = PostRequestDto(
postType = postType,
title = title,
body = body
)
repository.createCommunityPost(request)
.onSuccess {
- // Handle success
+ _state.value = _state.value.copy(
+ isLoading = false,
+ error = null
+ )
+ // Navigate or show success message
}
.onFailure {
- // Handle failure
+ _state.value = _state.value.copy(
+ isLoading = false,
+ error = it.message ?: "Post creation failed"
+ )
}
}
}Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In
app/src/main/java/com/hsLink/hslink/presentation/community/viewmodel/CommunityViewModel.kt
around lines 23 to 38, the createPost function currently has placeholder
success/failure handlers and does not update UI state; before calling
repository.createCommunityPost set the loading flag like _state.value =
_state.value.copy(isLoading = true), onSuccess update the state to reflect
success (e.g., clear error, set any success flag or emit a one-shot
navigation/event), onFailure set _state.value = _state.value.copy(error =
it.message) (and preserve any error details), and ensure you reset loading in a
finally-style path (or after both handlers) so _state.value =
_state.value.copy(isLoading = false) always runs.
ISSUE
❗ WORK DESCRIPTION
📸 SCREENSHOT
📢 TO REVIEWERS
Summary by CodeRabbit
Release Notes
New Features
Style