Fix examples 3-class and 7-pool
#4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation doesn't allow creating more than 1 instance and throws the following error in such case: ``` TypeError: Cannot redefine property: name ``` The reason is that `Object.defineProperty` defines properties directly for `Logable.prototype` instead of the instance being processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
3-classdoesn't allow creating more than 1 instance and throws the following error in such case:The reason is that
Object.definePropertydefines properties directly forLogable.prototypeinstead of the instance being processed.7-poolreferences to the name of the variable from the previous commit that has been changed. Therefore throws an error: