-
Notifications
You must be signed in to change notification settings - Fork 9
Chore/a11y improvements b light #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/a11y improvements b light #477
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR is detected, will deploy to dev environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements comprehensive accessibility improvements across the blog application, focusing on enhancing screen reader support, keyboard navigation, and semantic markup.
Key changes include:
- Added
aria-hidden="true"
to decorative SVG icons throughout the application - Improved keyboard navigation with focus management for article category tabs
- Enhanced semantic markup with proper ARIA labels and roles
- Created a new focusable directive for managing keyboard navigation
Reviewed Changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
tsconfig.base.json | Added path mapping for new ui-focusable library |
libs/blog/shared/ui-focusable/* | New library providing FocusableItemDirective for keyboard navigation |
libs/blog/shared/ui-social-media-icons/* | Improved ARIA labels with translatable text and hidden decorative icons |
libs/blog/search/* | Added dialog role and aria-hidden to decorative icons |
libs/blog/layouts/* | Enhanced navigation with proper ARIA labels and translatable text |
libs/blog/articles/* | Improved article card accessibility with proper link structure and hidden decorative icons |
libs/blog/newsletter/* | Added keyboard support for space key on checkbox and removed focus outline styles |
apps/blog/src/assets/i18n/* | Added new translation keys for accessibility labels |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
# ui-tooltip | ||
|
||
This library was generated with [Nx](https://nx.dev). | ||
|
||
## Running unit tests | ||
|
||
Run `nx test ui-tooltip` to execute the unit tests. |
Copilot
AI
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect library name in README title. Should be 'ui-focusable' not 'ui-tooltip'.
# ui-tooltip | |
This library was generated with [Nx](https://nx.dev). | |
## Running unit tests | |
Run `nx test ui-tooltip` to execute the unit tests. | |
# ui-focusable | |
This library was generated with [Nx](https://nx.dev). | |
## Running unit tests | |
Run `nx test ui-focusable` to execute the unit tests. |
Copilot uses AI. Check for mistakes.
# ui-tooltip | ||
|
||
This library was generated with [Nx](https://nx.dev). | ||
|
||
## Running unit tests | ||
|
||
Run `nx test ui-tooltip` to execute the unit tests. |
Copilot
AI
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect library name in test command. Should be 'ui-focusable' not 'ui-tooltip'.
# ui-tooltip | |
This library was generated with [Nx](https://nx.dev). | |
## Running unit tests | |
Run `nx test ui-tooltip` to execute the unit tests. | |
# ui-focusable | |
This library was generated with [Nx](https://nx.dev). | |
## Running unit tests | |
Run `nx test ui-focusable` to execute the unit tests. |
Copilot uses AI. Check for mistakes.
class="object-scale-down p-1" | ||
[ngSrc]="partner.asset_URL" | ||
[alt]="partner.alt" | ||
[alt]="" |
Copilot
AI
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty alt attribute for partner logos. Partner images should have meaningful alt text describing the partner name, not empty alt text.
[alt]="" | |
[alt]="partner.title" |
Copilot uses AI. Check for mistakes.
Deployed to dev environment |
No description provided.