Skip to content

fix(mcp): separate isolation note from first tool output - #133

Open
Audgui-Byte wants to merge 1 commit into
Hotragn:mainfrom
Audgui-Byte:fix-mcp-isolation-note-newline
Open

Audgui-Byte wants to merge 1 commit into
Hotragn:mainfrom
Audgui-Byte:fix-mcp-isolation-note-newline

Conversation

@Audgui-Byte

@Audgui-Byte Audgui-Byte commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

What does this change?

Add a trailing newline to the one-time MCP isolation note before the first tool result. Add an in-memory MCP client regression test that checks the combined text ends with a newline followed by command output, and that the note does not repeat on the second call.

Why?

Fixes #117. Previously the first command output could appear as isolation.hi when clients concatenate the text blocks.

How to test

  • Red/green: the new regression test failed before the change and passed after it.
  • vitest run packages/mcp: 42 passed, 1 skipped.
  • tsc -p packages/mcp/tsconfig.json --noEmit and tsc -p packages/mcp/tsconfig.build.json: passed.
  • node scripts/drift-check.mjs and node scripts/link-check.mjs: passed.
  • GitHub CI: all six package jobs across Node 20/22 and macOS/Ubuntu/Windows passed. Two Vercel preview checks require authorization from the upstream team.
  • The full monorepo Vitest run was attempted but did not pass in this Windows/pnpm checkout: 1,396 tests passed, 5 failed, and 19 files could not load, primarily in unrelated CLI/SDK/console tests. The MCP package had no failures. A real WSL2/local-provider smoke test was not available here.

Checklist

  • npm run build:packages && npm run typecheck && npm test passes locally
  • I exercised the changed MCP tool path through a linked in-memory client and server
  • New code follows the build contract
  • No new dependencies

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

@Audgui-Byte is attempting to deploy a commit to the hotragn's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the pkg: mcp Touches packages/mcp label Sep 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: mcp Touches packages/mcp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The MCP isolation banner has no trailing newline, so it runs into the first line of output

1 participant