♻️ Fix UI side warnings (#56)

Hona · Jul 3, 2024 · b611976 · b611976
1 parent fe4b163
commit b611976
Show file tree

Hide file tree

Showing 11 changed files with 32 additions and 44 deletions.
diff --git a/UI/src/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/Common/Statistic.razor b/UI/src/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/Common/Statistic.razor
@@ -7,9 +7,9 @@
 </FluentCard>
 
 @code {
-    [Parameter]
-    public string Value { get; set; }
+    [Parameter, EditorRequired]
+    public required string Value { get; set; }
 
-    [Parameter]
-    public string Label { get; set; }
+    [Parameter, EditorRequired]
+    public required string Label { get; set; }
 }
diff --git a/UI/src/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/Common/TierPill.razor b/UI/src/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/Common/TierPill.razor
@@ -7,13 +7,13 @@
 
 @code {
 
-    [Parameter]
-    public string Tier { get; set; }
+    [Parameter, EditorRequired]
+    public required string Tier { get; set; }
 
     [Parameter]
-    public string Style { get; set; }
+    public string? Style { get; set; }
 
-    private string GetStyle()
+    private string? GetStyle()
     {
         if (Tier is "0")
         {

diff --git a/UI/src/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/Layout/NavMenu.razor b/UI/src/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/Layout/NavMenu.razor
@@ -48,7 +48,7 @@
         NavigationManager.LocationChanged += HandleLocationChanged;
     }
 
-    public void HandleLocationChanged(object sender, LocationChangedEventArgs e)
+    public void HandleLocationChanged(object? sender, LocationChangedEventArgs e)
     {
         JS.InvokeVoidAsync("collapseNavMenu");
     }

diff --git a/UI/src/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/Layout/Search.razor b/UI/src/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/Layout/Search.razor
@@ -28,7 +28,7 @@
                     <FluentButton Appearance="Appearance.Stealth" IconStart="new Icons.Filled.Size12.Dismiss()" OnClick="HandleOnClose"/>
                 </FluentStack>
                 <FluentAutocomplete TOption="OneOf<ServerPlayerModel, MapInfo>"
-                                    OptionValue="@(x => x.Match(x => x?.Id.ToString(), x=> x?.Name))"
+                                    OptionValue="@(x => x.Match(x => x?.Id.ToString(), x => x?.Name))"
                                     Placeholder="Search everything"
                                     OnOptionsSearch="HandleOptionsSearch"
                                     SelectedOptionChanged="HandleSelectedOptionChanged"
@@ -73,9 +73,7 @@
     }
 
     private Timer? timer = null;
-
-    private FluentSearch? searchTest;
-
+
     private string? searchValue = null;
 
     private string? SearchValue
@@ -109,9 +107,7 @@
     private List<OneOf<ServerPlayerModel, MapInfo>>? defaultResults => null;
 
     private Dictionary<long, SteamProfile> _steamProfiles = new();
-
-    private bool _searchLoading;
-
+
     private async void TimerElapsed_TickAsync(object? sender, EventArgs e)
     {
         DisposeTimer();
@@ -133,7 +129,6 @@
     {
         if (!string.IsNullOrWhiteSpace(SearchValue))
         {
-            _searchLoading = true;
             await InvokeAsync(StateHasChanged);
 
             var results = await TempusClient.GetSearchResultAsync(SearchValue);
@@ -156,8 +151,6 @@
 
                     _steamProfiles = await TempusClient.GetSteamProfilesAsync(tempusPlayerIds);
                 }
-
-                _searchLoading = false;
             }
             else
             {
@@ -172,7 +165,6 @@
             await InvokeAsync(StateHasChanged);
         }
 
-        _searchLoading = false;
         if (_searchContext != null) _searchContext.Items = searchResults;
         await InvokeAsync(StateHasChanged);
     }

diff --git a/UI/src/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/Pages/Leaderboards/Map/MapHeader.razor b/UI/src/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/Pages/Leaderboards/Map/MapHeader.razor
@@ -9,22 +9,20 @@
             <FluentGridItem xs="12" sm="12" md="0">
                 <FluentStack Orientation="Orientation.Vertical" Style="margin-right: 1rem" Width="fit-content">
                     <h3>
-                        @Map?.MapInfo.Name
+                        @Map.MapInfo.Name
                     </h3>
 
                     <div>
                         <FluentStack HorizontalGap="2" Wrap>
                             <span style="padding-right: 0.125rem">Authored by</span>
-
-                            @if (Map != null)
+                            
+                            @foreach (var author in Map.Authors)
                             {
-                                foreach (var author in Map.Authors)
-                                {
-                                    <a href="/leaderboard/players/@author.PlayerInfo.Id">
-                                        @author.Name
-                                    </a>
-                                }
+                                <a href="/leaderboard/players/@author.PlayerInfo.Id">
+                                    @author.Name
+                                </a>
                             }
+
                         </FluentStack>
 
                         @((DateTimeOffset.UtcNow - Map.MapInfo.DateAdded.ToDateTimeOffset()).Humanize(maxUnit: TimeUnit.Year)) old
@@ -50,7 +48,7 @@
 
 @code
 {
-    [Parameter] public FullMapOverview2? Map { get; set; }
+    [Parameter, EditorRequired] public required FullMapOverview2 Map { get; set; }
 
     [Parameter] public Class Class { get; set; }
     [Parameter] public EventCallback<Class> ClassChanged { get; set; }

diff --git a/...c/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/Pages/Leaderboards/Map/MapRunsTable.razor b/...c/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/Pages/Leaderboards/Map/MapRunsTable.razor
@@ -51,8 +51,8 @@
 
 @code
 {
-    [Parameter]
-    public List<RecordInfoShort> Runs { get; set; }
+    [Parameter, EditorRequired]
+    public required List<RecordInfoShort> Runs { get; set; }
 
     [Parameter] 
     public Class Class { get; set; }

diff --git a/....WebUI/TF2Jump.WebUI.Client/Components/Pages/Leaderboards/Map/MapWorldRecordHistory.razor b/....WebUI/TF2Jump.WebUI.Client/Components/Pages/Leaderboards/Map/MapWorldRecordHistory.razor
@@ -18,11 +18,11 @@
 </div>
 @code {
     private List<Order> Orders { get; set; } = GetOrders();
-    private ApexChartOptions<Order> options;
+    private ApexChartOptions<Order> _options = null!;
 
     protected override void OnInitialized()
     {
-        options = new ApexChartOptions<Order>
+        _options = new ApexChartOptions<Order>
         {
             Chart = new Chart
             {
@@ -87,8 +87,8 @@ public static List<Order> GetOrders()
     public class Order
     {
         public Guid OrderId { get; set; } = Guid.NewGuid();
-        public string CustomerName { get; set; }
-        public string Country { get; set; }
+        public string? CustomerName { get; set; }
+        public string? Country { get; set; }
         public DateTimeOffset OrderDate { get; set; }
         public OrderType OrderType { get; set; }
         public decimal GrossValue { get; set; }

diff --git a/...F2Jump.WebUI/TF2Jump.WebUI.Client/Components/Pages/Leaderboards/Map/MapZoneSelector.razor b/...F2Jump.WebUI/TF2Jump.WebUI.Client/Components/Pages/Leaderboards/Map/MapZoneSelector.razor
@@ -13,8 +13,8 @@
 
 @code
 {
-    [Parameter]
-    public FullMapOverview2 Map { get; set; }
+    [Parameter, EditorRequired]
+    public required FullMapOverview2 Map { get; set; }
 
     [Parameter] public SelectedZone? SelectedZone { get; set; } = new(ZoneType.Map, 1);
     [Parameter] public EventCallback<SelectedZone?> SelectedZoneChanged { get; set; }

diff --git a/...ebUI/TF2Jump.WebUI.Client/Components/Pages/Leaderboards/Map/MapZoneSelectorTemplate.razor b/...ebUI/TF2Jump.WebUI.Client/Components/Pages/Leaderboards/Map/MapZoneSelectorTemplate.razor
@@ -56,11 +56,11 @@
     </FluentOption>
 }
 @code {
-    [Parameter]
-    public List<ZoneInfo> Zones { get; set; }
+    [Parameter, EditorRequired]
+    public required List<ZoneInfo> Zones { get; set; }
 
-    [Parameter]
-    public FullMapOverview2 Map { get; set; }
+    [Parameter, EditorRequired]
+    public required FullMapOverview2 Map { get; set; }
 
     [Parameter] public Class SelectedClass { get; set; }
 }
diff --git a/UI/src/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/_Imports.razor b/UI/src/TF2Jump.WebUI/TF2Jump.WebUI.Client/Components/_Imports.razor
@@ -11,7 +11,6 @@
 @using TF2Jump.WebUI
 @using TF2Jump.WebUI.Components
 @using TempusApi
-@using TF2Jump.WebUI.Client
 @using TF2Jump.WebUI.Client.Components.Common
 @using TF2Jump.WebUI.Utilities
 @using OneOf
diff --git a/UI/src/TF2Jump.WebUI/TF2Jump.WebUI/_Imports.razor b/UI/src/TF2Jump.WebUI/TF2Jump.WebUI/_Imports.razor
@@ -11,7 +11,6 @@
 @using TF2Jump.WebUI
 @using TF2Jump.WebUI.Components
 @using TempusApi
-@using TF2Jump.WebUI.Client
 @using TF2Jump.WebUI.Client.Components.Common
 @using TF2Jump.WebUI.Client.Components.Layout
 @using TF2Jump.WebUI.Utilities