Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0

- name: Setup Node
uses: actions/setup-node@v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: "22"
cache: npm

- name: Setup Python
uses: actions/setup-python@v5
uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
with:
python-version: "3.12"
cache: pip
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:

steps:
- name: Checkout NodeRoom
uses: actions/checkout@v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
ref: ${{ github.event.pull_request.head.sha || github.sha }}
path: noderoom
Expand All @@ -75,14 +75,14 @@ jobs:
echo "sha=$sha" >> "$GITHUB_OUTPUT"

- name: Checkout NodeSlide package producer
uses: actions/checkout@v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
repository: HomenShum/NodeSlide
ref: ${{ steps.nodeslide-release.outputs.sha }}
path: nodeslide

- name: Setup Node
uses: actions/setup-node@v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: "22"
cache: npm
Expand Down Expand Up @@ -126,7 +126,7 @@ jobs:
run: npm run nodeslide:mounted:release:proof -- --json-out nodeslide-mounted-release-proof.json

- name: Upload mounted release receipt
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: nodeslide-mounted-release-${{ github.run_id }}
path: noderoom/nodeslide-mounted-release-proof.json
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/design-gate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
env:
QA_BASE_URL: http://localhost:5301
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
cache: npm
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:

- name: Upload design-QA reports
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: design-qa-reports
path: .tmp-qa/**
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/node-platform-conformance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ permissions:

jobs:
node-platform:
uses: HomenShum/node-platform/.github/workflows/repo-conformance.yml@ef4ac8a011b230efa3324892a193abe02ff2d673
uses: HomenShum/node-platform/.github/workflows/repo-conformance.yml@5c9aa6443ca8e61dc8886fbf0a0b4a7b72858e63 # Node 24 action pins (PR #8)
4 changes: 2 additions & 2 deletions .github/workflows/proofloop-gate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ jobs:
proofloop-gate:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
- run: npm ci
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/proofloop-suites.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
cache: npm
Expand All @@ -28,7 +28,7 @@ jobs:
CI: "true"
- name: Upload proof artifacts
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: proofloop-accounting
path: .proofloop/runs/latest/
Expand All @@ -39,8 +39,8 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
cache: npm
Expand All @@ -52,7 +52,7 @@ jobs:
CI: "true"
- name: Upload proof artifacts
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: proofloop-notion
path: .proofloop/runs/latest/
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/proofloop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
cache: npm
Expand All @@ -23,7 +23,7 @@ jobs:
VITE_CONVEX_URL: ${{ secrets.VITE_CONVEX_URL }}
- name: Upload proof artifacts
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: proximitty-underwriting-pr0
path: .proofloop/runs/latest/
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/refresh-design-baselines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
env:
QA_BASE_URL: http://localhost:5301
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
cache: npm
Expand All @@ -28,7 +28,7 @@ jobs:
run: npx playwright test design-baseline --update-snapshots
- name: Upload refreshed snapshots
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: design-baselines
path: e2e/design-baseline.spec.ts-snapshots/**
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/scaffold-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ jobs:
scaffold-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0

- uses: actions/setup-node@v4
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22

Expand Down Expand Up @@ -46,7 +46,7 @@ jobs:
- name: Post scaffold report as PR comment
if: always() && steps.handoff.outputs.exists == 'true'
continue-on-error: true
uses: actions/github-script@v7
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
with:
script: |
const fs = require('fs');
Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:

- name: Upload scaffold artifacts
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: scaffold-report
path: |
Expand Down
4 changes: 2 additions & 2 deletions proofloop/templates/github-proofloop-gate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ jobs:
proofloop-gate:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
- run: npm ci
Expand Down
57 changes: 57 additions & 0 deletions tests/githubActionsRuntimePins.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
import { readdirSync, readFileSync } from "node:fs";
import { join } from "node:path";
import { describe, expect, it } from "vitest";

const expectedPins = {
checkout: {
sha: "3d3c42e5aac5ba805825da76410c181273ba90b1",
version: "v7.0.1",
},
"setup-node": {
sha: "820762786026740c76f36085b0efc47a31fe5020",
version: "v7.0.0",
},
"setup-python": {
sha: "5fda3b95a4ea91299a34e894583c3862153e4b97",
version: "v7.0.0",
},
"upload-artifact": {
sha: "043fb46d1a93c77aae656e7c1c64a875d1fc6a0a",
version: "v7.0.1",
},
"github-script": {
sha: "3a2844b7e9c422d3c10d287c895573f7108da1b3",
version: "v9.0.0",
},
} as const;

const workflowDirectory = join(process.cwd(), ".github", "workflows");
const workflowFiles = readdirSync(workflowDirectory)
.filter((name) => name.endsWith(".yml") || name.endsWith(".yaml"))
.map((name) => join(workflowDirectory, name));
const files = [...workflowFiles, join(process.cwd(), "proofloop", "templates", "github-proofloop-gate.yml")];

describe("GitHub Actions JavaScript runtime pins", () => {
it("uses immutable Node 24 release commits with readable version comments", () => {
for (const file of files) {
const lines = readFileSync(file, "utf8").split(/\r?\n/);

for (const [index, line] of lines.entries()) {
const action = Object.keys(expectedPins).find((name) => line.includes(`actions/${name}@`));
if (!action) continue;

const pin = expectedPins[action as keyof typeof expectedPins];
expect(line.trim(), `${file}:${index + 1}`).toContain(
`uses: actions/${action}@${pin.sha} # ${pin.version}`,
);
}
}
});

it("binds Node Platform conformance to the warning-free immutable producer", () => {
const workflow = readFileSync(join(workflowDirectory, "node-platform-conformance.yml"), "utf8");
expect(workflow).toContain(
"HomenShum/node-platform/.github/workflows/repo-conformance.yml@5c9aa6443ca8e61dc8886fbf0a0b4a7b72858e63 # Node 24 action pins (PR #8)",
);
});
});
3 changes: 2 additions & 1 deletion tests/proofloopCi.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ describe("proofloop ci install github", () => {
const workflow = readFileSync(result.workflowPath, "utf8");
// The exact gate contract from scripts/proofloop-cli.ts cmdGoalGate.
expect(workflow).toContain("npx tsx scripts/proofloop-cli.ts gate --goal official-scores");
expect(workflow).toContain("actions/setup-node@v4");
expect(workflow).toContain("actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1");
expect(workflow).toContain("actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0");
expect(workflow).toContain("node-version: 22");
expect(workflow).toContain("npm ci");
expect(workflow).not.toContain(PROOFLOOP_CI_GOAL_PLACEHOLDER);
Expand Down
Loading