-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 3 working branch #177
Conversation
4b24473
to
0d47178
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far!
Off-topic: are |
They were ActiveSupport stuff removed with Homebrew/brew#14778. The code here just never got updated, nor is it a code path CI covers. I suppose that's a problem shared with all of the ActiveSupport extensions - they're not explicitly a part of our public API but some are highly used regardless in homebrew-core etc. |
This is probably ready to tag a release on and to add an opt-in within brew. I could either tag a release as "3.1.4-rc.homebrew1" or just do "3.1.4" and revision bump if it ends up having issues. I don't anticipate any though and will test a bit locally. |
Let's keep it in line with the normal versions and do rev bumps if needed |
Agreed. Let's version this normally and then can make it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good,. nice work!
(today) |
Tests for Ruby 3.2.
What I plan for this branch:
brew
itself supports handling of Ruby 3 gems).brew
.Don't really want to faff around with versioned formulae and adjusting all the workflows to build twice when branches work fine for this purpose, are simpler and make the diff easier to follow.