Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 working branch #177

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Ruby 3 working branch #177

merged 3 commits into from
Oct 26, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Aug 22, 2023

Tests for Ruby 3.2.

What I plan for this branch:

  • This will be rebased as necessary until all builds pass and the "TEMP: workflow workarounds for ruby3 branch" commit is no longer required (i.e. brew itself supports handling of Ruby 3 gems).
  • At that point, I'll make it a protected branch and we can make releases from that branch that we can use in brew.
  • When Ruby 2.6 is killed (i.e. we are sure we will never need to make another Portable Ruby 2.6 release again), then this PR can be merged.

Don't really want to faff around with versioned formulae and adjusting all the workflows to build twice when branches work fine for this purpose, are simpler and make the diff easier to follow.

@Bo98 Bo98 force-pushed the ruby3 branch 9 times, most recently from 4b24473 to 0d47178 Compare August 23, 2023 04:01
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far!

Formula/portable-ruby.rb Outdated Show resolved Hide resolved
@EricFromCanada
Copy link
Member

Off-topic: are .humanize and .titleize in Abstract/portable-formula.rb vestigial remains of an older way of handling macOS version names? They don't seem to be defined anywhere.

@Bo98
Copy link
Member Author

Bo98 commented Aug 25, 2023

They were ActiveSupport stuff removed with Homebrew/brew#14778. The code here just never got updated, nor is it a code path CI covers.

I suppose that's a problem shared with all of the ActiveSupport extensions - they're not explicitly a part of our public API but some are highly used regardless in homebrew-core etc.

@Bo98
Copy link
Member Author

Bo98 commented Sep 29, 2023

This is probably ready to tag a release on and to add an opt-in within brew.

I could either tag a release as "3.1.4-rc.homebrew1" or just do "3.1.4" and revision bump if it ends up having issues. I don't anticipate any though and will test a bit locally.

@SMillerDev
Copy link
Member

Let's keep it in line with the normal versions and do rev bumps if needed

@MikeMcQuaid
Copy link
Member

Agreed. Let's version this normally and then can make it HOMEBREW_DEVELOPER only for some Homebrew/brew testing and then get it early on a tag for testing before stable branch folks.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,. nice work!

@Bo98
Copy link
Member Author

Bo98 commented Oct 26, 2023

HOMEBREW_RUBY3 🔜

(today)

@Bo98 Bo98 marked this pull request as ready for review October 26, 2023 15:44
@Bo98 Bo98 merged commit b4ad12a into master Oct 26, 2023
4 checks passed
@Bo98 Bo98 deleted the ruby3 branch October 26, 2023 15:44
@Bo98 Bo98 removed the in progress label Oct 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants