curl: enable libpsl#289395
Conversation
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
|
Feel free to take over this PR to address any pending issues, my motivation was to point out that PSL is not enabled (very likely by mistake) and the PR was simple enough, but I don't plan on spending more time on this, sorry. |
|
As a curl maintainer, I can only say 👍 PSL should be enabled by default methinks. |
Build with libpsl to turn on Public Suffix List checks, so cookies can't be set for broad public suffixes like `.co.uk`; this blocks "supercookies" that would otherwise be shared across unrelated sites under the same suffix.
|
Looks good but we probably need rockdaboot/libpsl#257 to make it to a release first otherwise curl will require Python.
I believe this was raised once before and the Python requirement was the main issue, but looks like it's fixed now (but with no release yet). |
Build with libpsl to turn on Public Suffix List checks, so cookies can't be set for broad public suffixes like
.co.uk; this blocks "supercookies" that would otherwise be shared across unrelated sites under the same suffix.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?