Skip to content

curl: enable libpsl#289395

Open
samueloph wants to merge 1 commit into
Homebrew:mainfrom
samueloph:curl-libpsl
Open

curl: enable libpsl#289395
samueloph wants to merge 1 commit into
Homebrew:mainfrom
samueloph:curl-libpsl

Conversation

@samueloph

Copy link
Copy Markdown

Build with libpsl to turn on Public Suffix List checks, so cookies can't be set for broad public suffixes like .co.uk; this blocks "supercookies" that would otherwise be shared across unrelated sites under the same suffix.


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

@github-actions github-actions Bot added the CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. label Jun 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@samueloph

Copy link
Copy Markdown
Author

Feel free to take over this PR to address any pending issues, my motivation was to point out that PSL is not enabled (very likely by mistake) and the PR was simple enough, but I don't plan on spending more time on this, sorry.

@bagder

bagder commented Jun 23, 2026

Copy link
Copy Markdown

As a curl maintainer, I can only say 👍

PSL should be enabled by default methinks.

Comment thread Formula/c/curl.rb Outdated
Build with libpsl to turn on Public Suffix List checks, so cookies
can't be set for broad public suffixes like `.co.uk`; this blocks
"supercookies" that would otherwise be shared across unrelated sites
under the same suffix.
@Bo98

Bo98 commented Jun 23, 2026

Copy link
Copy Markdown
Member

Looks good but we probably need rockdaboot/libpsl#257 to make it to a release first otherwise curl will require Python.

very likely by mistake

I believe this was raised once before and the Python requirement was the main issue, but looks like it's fixed now (but with no release yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants