Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.Details
release notes
max_manifest_file_sizeis repeatedly exceeded. The new recommendation is to setmax_manifest_file_sizeto something small like 1MB and tunemax_manifest_space_amp_pctas needed to balance write amp and space amp in the manifest. Refer to comments on those options inDBOptionsfor details. Both options are (now) mutable.Public API Changes
ROCKSDB_USING_THREAD_STATUShas been removed from public headers and replaced with staticconst bool ThreadStatus::kEnabled. Some other uses of conditional compilation have been removed from public API headers to reduce risk of ODR violations or other issues.Behavior Changes
Bug Fixes
DB::GetSortedWalFiles()could hang when waiting for a purge operation that found nothing to do (potentially triggered by iterator release, flush, compaction, etc.).max_sequential_skip_in_iterationscould cause the iterator to seek backward to already-unpinned blocks when the same user key spans multiple data blocks, leading to assertion failures or seg fault.WAL_ttl_seconds > 0use cases where the newest archived WAL files could be incorrectly deleted when the system clock moved backwards.Performance Improvements
View the full release notes at https://github.com/facebook/rocksdb/releases/tag/v10.9.1.