Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing formuale that are not compatible with go1.14 #52184

Closed
1 of 6 tasks
roopakv opened this issue Mar 26, 2020 · 7 comments
Closed
1 of 6 tasks

Fixing formuale that are not compatible with go1.14 #52184

roopakv opened this issue Mar 26, 2020 · 7 comments
Labels
outdated PR was locked due to age stale No recent activity

Comments

@roopakv
Copy link
Contributor

roopakv commented Mar 26, 2020

Continuation of discussion from #51909. Moving out to unblock 1.14.1

The following formuale have issues on master (quoting @Bo98):

@miha-pece
Copy link

Syncthing formula also has a problem, my is now broken when I upgraded to 1.4.0. More informed persons than me are pointing to problems with go 1.14 (link).

@Bo98
Copy link
Member

Bo98 commented Apr 5, 2020

I am unable to reproduce the issue. Is there a particular command or configuration you are using that triggers the crash?

I can go ahead ship a new build with Go 1.14.1 regardless. A test case would have just been useful to prevent it reoccurring.

@miha-pece
Copy link

The issue is probably relevant for older processors. I have Mac Pro 2009. That was suggested:
syncthing/syncthing-macos#107 (comment)

@Bo98
Copy link
Member

Bo98 commented Apr 8, 2020

@miha-pece Can you try again now? It should be working now upon a brew upgrade syncthing.

@miha-pece
Copy link

It works now, thank you.

@stale
Copy link

stale bot commented May 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label May 2, 2020
@stale stale bot closed this as completed May 9, 2020
@roopakv roopakv mentioned this issue Jun 11, 2020
@ryboe
Copy link

ryboe commented Jun 16, 2020

A new release of charmstore-client just landed.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 2, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

No branches or pull requests

5 participants