-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go 1.14.4 upgrade failures #56539
Comments
@Bo98 I would love to help to either remove these or fix them. I don't understand how to decide so please let me know what needs to be done and I'll get on it |
Just update to the latest go and run one of the commands above. It won't complete succesfully but from there you can fix it. |
@SMillerDev the thing is, many of these repos like wellington or perkeep have issues building, or changes need to happen in those repos. In those cases I have already filed issues or sent PRs to some of those repos (around go 1.14.1's release). There has been no response. IMHO in those cases the best case should be to remove from brew? I could go an do the issue filing for the remaining repos but want to make sure there is one strategy we use for all the failing formulae issue where this was discussed before: #52184 |
If upstream doesn't respond and it doesn't build the formula can be removed. But we should try and help them first, preferably by providing pull requests. |
So in a case like this: buger/goreplay#739 where I have opened an issue for them to cut a new release and they haven't done so yet, can I go ahead and send a PR removing the |
While that's an edge case where they have the support but no release, but since it barely has any installs... sure. |
Just fired off an email to three |
Install for |
|
|
|
|
The test might be flaky tho. Since it relies on a video that is pulled from internet. |
Closing this in favor of go1.15 upgrade failure tracker |
From #55639
@Bo98 will let you edit this with more detail when you get a chance!
The text was updated successfully, but these errors were encountered: