Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.14.4 upgrade failures #56539

Closed
MikeMcQuaid opened this issue Jun 19, 2020 · 14 comments
Closed

Go 1.14.4 upgrade failures #56539

MikeMcQuaid opened this issue Jun 19, 2020 · 14 comments
Labels
go Go use is a significant feature of the PR or issue help wanted Task(s) needing PRs from the community or maintainers outdated PR was locked due to age

Comments

@MikeMcQuaid
Copy link
Member

From #55639

brew test --verbose annie
brew install --build-from-source charm
brew test --verbose darksky-weather
brew install --build-from-source dashing
brew test --verbose dashing
brew install --build-from-source dvm
brew test --verbose faas-cli
brew install --build-from-source gor
brew test --verbose jabba
rm -rf /Users/brew/Library/Caches/Homebrew
brew install --build-from-source perkeep
brew install --build-from-source source-to-image
brew install --build-from-source sync_gateway
brew install --build-from-source wellington

@Bo98 will let you edit this with more detail when you get a chance!

@MikeMcQuaid MikeMcQuaid added the help wanted Task(s) needing PRs from the community or maintainers label Jun 19, 2020
@dawidd6 dawidd6 added the go Go use is a significant feature of the PR or issue label Jun 19, 2020
@roopakv
Copy link
Contributor

roopakv commented Jun 19, 2020

@Bo98 I would love to help to either remove these or fix them. I don't understand how to decide so please let me know what needs to be done and I'll get on it

@SMillerDev
Copy link
Member

Just update to the latest go and run one of the commands above. It won't complete succesfully but from there you can fix it.

@roopakv
Copy link
Contributor

roopakv commented Jun 19, 2020

@SMillerDev the thing is, many of these repos like wellington or perkeep have issues building, or changes need to happen in those repos. In those cases I have already filed issues or sent PRs to some of those repos (around go 1.14.1's release). There has been no response.

IMHO in those cases the best case should be to remove from brew?

I could go an do the issue filing for the remaining repos but want to make sure there is one strategy we use for all the failing formulae

issue where this was discussed before: #52184

@SMillerDev
Copy link
Member

If upstream doesn't respond and it doesn't build the formula can be removed. But we should try and help them first, preferably by providing pull requests.

@roopakv
Copy link
Contributor

roopakv commented Jun 19, 2020

So in a case like this: buger/goreplay#739 where I have opened an issue for them to cut a new release and they haven't done so yet, can I go ahead and send a PR removing the gor formula?

@SMillerDev
Copy link
Member

While that's an edge case where they have the support but no release, but since it barely has any installs... sure.

@alebcay
Copy link
Member

alebcay commented Jun 19, 2020

Just fired off an email to three goreplay devs - hopefully that will garner more of a response 🤞.

@alebcay
Copy link
Member

alebcay commented Jun 23, 2020

Install for source-to-image is failing due to upstream tag's revision seeming to have changed. Opened an issue asking for upstream to clarify on this change: openshift/source-to-image#1047.

@alebcay
Copy link
Member

alebcay commented Jun 23, 2020

dvm should be fixed by #56740.

@dawidd6
Copy link
Contributor

dawidd6 commented Jun 23, 2020

wellington: wellington/wellington#218

@alebcay
Copy link
Member

alebcay commented Jun 25, 2020

source-to-image should be fixed by #56836.

@alebcay
Copy link
Member

alebcay commented Jun 26, 2020

annie seems to have worked without any issues in #56867.

@dawidd6
Copy link
Contributor

dawidd6 commented Jun 26, 2020

annie seems to have worked without any issues in #56867.

The test might be flaky tho. Since it relies on a video that is pulled from internet.

This was referenced Jul 26, 2020
This was referenced Aug 7, 2020
@chenrui333
Copy link
Member

chenrui333 commented Aug 15, 2020

Closing this in favor of go1.15 upgrade failure tracker

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue help wanted Task(s) needing PRs from the community or maintainers outdated PR was locked due to age
Projects
None yet
Development

No branches or pull requests

7 participants