Skip to content

feat(anlz): Add Support for 3-Band Waveforms#239

Merged
Swiftb0y merged 4 commits into
Holzhaus:mainfrom
FizzyApple12:development
Jun 1, 2026
Merged

feat(anlz): Add Support for 3-Band Waveforms#239
Swiftb0y merged 4 commits into
Holzhaus:mainfrom
FizzyApple12:development

Conversation

@FizzyApple12

@FizzyApple12 FizzyApple12 commented May 27, 2026

Copy link
Copy Markdown
Contributor

This PR does the following:

  1. Adds Waveform3BandPreview, Waveform3BandPreviewColumn, Waveform3BandDetail, and Waveform3BandDetailColumn structs based on the information here and here
  2. Adds Waveform3BandPreview (magic PWV6) and Waveform3BandDetail (magic PWV7) to ContentKind
  3. AddsWaveform3BandPreview and Waveform3BandDetail to Content
  4. Cleans up a the documentation around the Waveforms to make the comments point to the correct links and have consistent descriptions

@acrilique acrilique left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I just left a couple of comments. Feel free to address them while you wait for a review by someone with write access.

Comment thread flake.nix Outdated
Comment thread src/anlz.rs
@Swiftb0y

Copy link
Copy Markdown
Collaborator

It would be nice to have some tests for these to ensure stability. We already have some .2EX files in the complete_export dataset.

@FizzyApple12

Copy link
Copy Markdown
Contributor Author

The existing parsing tests that exist for anlz pass with this code, if there's interest I can make some more that test parsing individual parts of the data in the files though

@Swiftb0y

Copy link
Copy Markdown
Collaborator

Ah right, anlz has no unit tests, only a basic read-write integration test.

@Swiftb0y Swiftb0y left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@FizzyApple12

Copy link
Copy Markdown
Contributor Author

Of course! I'm glad to contribute!

@Swiftb0y
Swiftb0y merged commit 8792e49 into Holzhaus:main Jun 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants