feat(anlz): Add Support for 3-Band Waveforms#239
Merged
Conversation
acrilique
requested changes
May 27, 2026
acrilique
left a comment
Collaborator
There was a problem hiding this comment.
Hi! I just left a couple of comments. Feel free to address them while you wait for a review by someone with write access.
This reverts commit 2b767e9.
Collaborator
|
It would be nice to have some tests for these to ensure stability. We already have some |
Contributor
Author
|
The existing parsing tests that exist for anlz pass with this code, if there's interest I can make some more that test parsing individual parts of the data in the files though |
Collaborator
|
Ah right, anlz has no unit tests, only a basic read-write integration test. |
Contributor
Author
|
Of course! I'm glad to contribute! |
acrilique
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Waveform3BandPreview,Waveform3BandPreviewColumn,Waveform3BandDetail, andWaveform3BandDetailColumnstructs based on the information here and hereWaveform3BandPreview(magicPWV6) andWaveform3BandDetail(magicPWV7) toContentKindWaveform3BandPreviewandWaveform3BandDetailtoContent