Skip to content

LVT-75: Truncate decimals in analysis output #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackattack-4 merged 3 commits into from
Jan 9, 2026
Merged

LVT-75: Truncate decimals in analysis output #44

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b107b48
round literally all analysis outputs to two decimal places
jackattack-4 Jan 5, 2026
313230f
Update src/handler/analysis/analysisFunction.ts
jackattack-4 Jan 5, 2026
848c4c8
implement suggestions
jackattack-4 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions src/handler/analysis/analysisFunction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,24 @@ export async function runAnalysis<T extends z.ZodObject, R extends z.ZodType>(
},
};

const roundAllNumbers = <T>(val: T): T => {
if (val === null || val === undefined) return val;
if (typeof val === "number") return Math.round(val * 100) / 100 as T;
if (Array.isArray(val)) return val.map(roundAllNumbers) as T;
if (typeof val === "object") {
const out: Record<string, unknown> = {};
for (const k of Object.keys(val as Record<string, unknown>)) {
out[k] = roundAllNumbers((val as Record<string, unknown>)[k]);
}
return out as T;
}
return val as T;
};

if (!config.shouldCache) {
return await config.calculateAnalysis(passedArgs, context);
const fresh = await config.calculateAnalysis(passedArgs, context);
const rounded = roundAllNumbers(fresh);
return rounded;
}

const {
Expand All @@ -63,16 +79,18 @@ export async function runAnalysis<T extends z.ZodObject, R extends z.ZodType>(

if (!cacheRow) {
const result = await config.calculateAnalysis(passedArgs, context);
const rounded = roundAllNumbers(result);

await kv.set(key, JSON.stringify(result));
await kv.set(key, JSON.stringify(rounded));
await prismaClient.cachedAnalysis.create({
data: {
key,
teamDependencies: teamDependencies ?? [],
tournamentDependencies: tournamentDependencies ?? [],
},
});
return result;

return rounded as z.infer<R>;
}

const parsed = JSON.parse(cacheRow.toString());
Expand Down
Loading