Fix BungeeCord support to use BungeeCord's own GUID#40
Open
roblabla wants to merge 1 commit into
Open
Conversation
Owner
|
Out of curiosity, if you're still active, are you able to update this PR to not have conflicts on the latest version? If so, I can immediately merge it. If not, it is no problem and I'll look through this after I have a Bungee test server and can then test it on Bungee. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
So after talking to md_5, creator of bungeecord, I discovered BungeeCord already "implements" metrics to keep track of how many servers run bungee, and as such has it's own GUID. This PR changes the GUID to use bungeecord's.
Also, the way to opt-out of metrics in bungeecord is to set the GUID to "null" in the config. As such, I added a check in isOptOut to see if the GUID was changed to null.