Skip to content

[Refactor/#591] Remove build warnings #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
angryPodo wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[Refactor/#591] Remove build warnings #594

angryPodo wants to merge 3 commits into from
+42 โˆ’38

Conversation

@angryPodo
Copy link
Member

@angryPodo angryPodo commented Dec 30, 2025

Related issue ๐Ÿ› 

Work Description โœ๏ธ

  • :core:designsystem: HilingualBasicPicker.kt์—์„œ ๋ถˆํ•„์š”ํ•œ toString() ๋ณ€ํ™˜ ํ˜ธ์ถœ์„ ์ œ๊ฑฐํ•˜์—ฌ ๊ฒฝ๊ณ ๋ฅผ ํ•ด๊ฒฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • :data:feed: UserListModel.kt์—์„œ Non-nullable ํƒ€์ž…์— ์‚ฌ์šฉ๋œ ๋ถˆํ•„์š”ํ•œ !! (Non-null assertion)์„ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • :presentation:diarywrite: DiaryWriteScreen.kt์—์„œ Deprecated๋œ Balloon ์ปดํฌ์ €๋ธ” ์‚ฌ์šฉ์„ Modifier.balloon ๋ฐ rememberBalloonState๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ์ตœ์‹  API๋กœ ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ํ–ˆ์Šต๋‹ˆ๋‹ค.

Uncompleted Tasks ๐Ÿ˜…

  • Gradle Multi-string notation ๊ฒฝ๊ณ  (AGP ๋‚ด๋ถ€ ๋ฌธ์ œ๋กœ ํŒ๋‹จ๋˜์–ด ๋ณด๋ฅ˜)

To Reviewers ๐Ÿ“ข

  • ๋นŒ๋“œ ์‹œ ๋ฐœ์ƒํ•˜๋˜ Kotlin ์ปดํŒŒ์ผ๋Ÿฌ ๊ฒฝ๊ณ ๋“ค์„ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • Balloon ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜์ด ํฌํ•จ๋˜์–ด ์žˆ์œผ๋‹ˆ, ์ผ๊ธฐ ์ž‘์„ฑ ํ™”๋ฉด์˜ ํˆดํŒ ๋™์ž‘ ํ™•์ธ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

@angryPodo angryPodo self-assigned this Dec 30, 2025
@angryPodo angryPodo requested a review from a team as a code owner December 30, 2025 13:05
@angryPodo angryPodo requested review from Daljyeong, Hyobeen-Park, nahy-512 and nhyeonii and removed request for a team December 30, 2025 13:05
@angryPodo angryPodo added REFACTOR๐Ÿงฝ ๊ธฐ๋Šฅ ๋™์ž‘์€ ์œ ์ง€ํ•˜๋˜, ์•ฑ ๋กœ์ง(ํ”„๋กœ๋•์…˜ ์ฝ”๋“œ)์˜ ๊ตฌ์กฐ์™€ ํ’ˆ์งˆ์„ ๊ฐœ์„  ๐Ÿ€๋ฏผ์žฌ ๋ฏผ์žฌ ๋‹ด๋‹น labels Dec 30, 2025
@angryPodo angryPodo linked an issue Dec 30, 2025 that may be closed by this pull request
[REFACTOR] Remove build warnings #591
Open
nahy-512
nahy-512 approved these changes Dec 30, 2025
View reviewed changes
Copy link
Member

@nahy-512 nahy-512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nahy-512 nahy-512 nahy-512 approved these changes

@Hyobeen-Park Hyobeen-Park Awaiting requested review from Hyobeen-Park Hyobeen-Park is a code owner automatically assigned from Hi-lingual/team-android

@Daljyeong Daljyeong Awaiting requested review from Daljyeong Daljyeong is a code owner automatically assigned from Hi-lingual/team-android

@nhyeonii nhyeonii Awaiting requested review from nhyeonii nhyeonii is a code owner automatically assigned from Hi-lingual/team-android

Assignees

@angryPodo angryPodo

Labels

REFACTOR๐Ÿงฝ ๊ธฐ๋Šฅ ๋™์ž‘์€ ์œ ์ง€ํ•˜๋˜, ์•ฑ ๋กœ์ง(ํ”„๋กœ๋•์…˜ ์ฝ”๋“œ)์˜ ๊ตฌ์กฐ์™€ ํ’ˆ์งˆ์„ ๊ฐœ์„  ๐Ÿ€๋ฏผ์žฌ ๋ฏผ์žฌ ๋‹ด๋‹น

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[REFACTOR] Remove build warnings

3 participants

@angryPodo @nahy-512