Fix VideoQuality.fromLabel to match higher resolutions first

[jamiepiccolo]

VideoQuality.fromLabel would give incorrect qualities in some cases.

An example being the 1440p label where the method would assign VideoQuality.low144 because of a premature match of the string's prefix "144":

if (label.startsWith('144')) {
    return VideoQuality.low144;
}

...

if (label.startsWith('1440')) {
    return VideoQuality.high1440;
}

I simply reversed the resolution map and looped over it so that we start matching from the highest resolution first.

[khaled-0]

Now how would one target 144p
because it'll always match 1440p
previous solution was fine.

[jamiepiccolo]

If you could provide more insight into how this would prematurely match 1440p for 144p let me know.

The previous solution didn’t work, which is why I made this pull request. Although I haven’t used the package for quite some time, so things may have changed.

[khaled-0]

For 144p
if label startsWith "144" then by reverse order "1440p" will be the first match,

[jamiepiccolo]

Ah yes, you’re right. I just reversed the issue. Unfortunately it is still a bug either way, but this isn’t the solution.

Feel free to close, I have no time to propose a proper solution.