Skip to content

Improve metadata / PDC usage #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 23, 2025
Merged

Improve metadata / PDC usage #183

merged 10 commits into from
May 23, 2025

Conversation

BlitzOffline
Copy link
Member

@BlitzOffline BlitzOffline commented Mar 23, 2025 •
edited
Loading

This PR improves the current PDC usage and adds new commands for handling use metadata.

For DeluxeMenus users:

Added:

  • Commands for handling metadata (with support for placeholders):
    • show: Gets the stored value at the specified key as long as it matches the specified type
    • list: List all key-value pairs of a specified type
    • set: Set a value of specified type at the specified key (if a value exists at the given key, it will override it only if the type matches)
    • remove: Remove a value of specified type from the specified key (as long as existent value matches the given type)
    • add: Used for addition on number types (If no value exists at the given key yet, the addition will be done on a 0 value)
    • subtract: Used for subtraction on number types (If no value exists at the given key yet, the subtraction will be done on a 0 value)
    • switch: Used for switching boolean values. Since BOOLEAN type is just an alias for String, it will also work for String types as long as the values are true or false (case insensitive)
  • Placeholders list (They will show in /papi info deluxemenus)

Changed:

  • The %deluxemenus_meta_has_value_<key>_[type]% placeholder no longer requires a type to be specified. If no type is specified, all supported types will be checked.
  • The help command has 2 variants now: OP and ADMIN. OP variant displays all DM commands, ADMIN variant displays only the commands that do not require OP.

For DeluxeMenus developers:

  • Overhauled the entire PMH API:
    • Added separate methods for every available action: switch, add, remove, etc.
    • Added a new OperationResult enum to better relay PMH results.
    • Added a DataType layer above PDTs for ease of use (especially when it comes to BOOLEANS which are fancy STRINGS)
  • Added some pagination utils (used in the /dm list and /dm meta list commands)

Closes #134

@BlitzOffline
Commiting to not lose stuff. Should've done this a long time ago
a8fdaea
@BlitzOffline
fixed some stuff, not tested yet
32316ab
@BlitzOffline
General improvements and fixes for Meta.
9e689df 
- Improved some error messages,
- Added a bridge DataType between strings and supported PDTs
- Improved the meta_ placeholders
- Made the type optional for meta_has_value placeholder
- PMH#hasMeta now only checks the supported types if no type is specified.
@BlitzOffline BlitzOffline changed the title Added tab completion for all admin commands Improve metadata / PDC usage Mar 23, 2025
Tanguygab
Tanguygab previously approved these changes Mar 23, 2025
View reviewed changes
@BlitzOffline BlitzOffline dismissed Tanguygab’s stale review March 23, 2025 20:43

The merge-base changed after approval.

@NoltoxGit
Copy link

Hello !
Do you have a ETA for when this PR will be merged/stable, so I can use it on my server? 👀

@BlitzOffline
Copy link
Member Author

Hello ! Do you have a ETA for when this PR will be merged/stable, so I can use it on my server? 👀

I have tested about 90% of the changes. I still have to test the meta placeholders and make sure they work properly and then we should be good to go. I'm not sure when I'll have time to do that.

@BlitzOffline BlitzOffline marked this pull request as ready for review April 5, 2025 02:29
@BlitzOffline
Copy link
Member Author

This PR is ready for code review. Tested on Paper version 1.21.4-164-main@8eb8e44.

@NoltoxGit if you want to give this build a try before it is merged, you can use the following file (unzip it first):
DeluxeMenus-1.14.1-DEV-local-build.jar.zip

@NoltoxGit
Copy link

This PR is ready for code review. Tested on Paper version 1.21.4-164-main@8eb8e44.

@NoltoxGit if you want to give this build a try before it is merged, you can use the following file (unzip it first): DeluxeMenus-1.14.1-DEV-local-build.jar.zip

Hi,
I'll try this, thank you so much! <3

@NoltoxGit
Copy link

This PR is ready for code review. Tested on Paper version 1.21.4-164-main@8eb8e44.

@NoltoxGit if you want to give this build a try before it is merged, you can use the following file (unzip it first): DeluxeMenus-1.14.1-DEV-local-build.jar.zip

I've just tested the version, it's look work great! And have a suggestion:

  • Would it be possible to make the /dmenu meta <player> list directly display all the meta assigned to it without having to specify the parameter?

@BlitzOffline
Copy link
Member Author

It is possible to add such a command, but, unfortunately, due to how we store values, it would be buggy when determining what type a value is. This is the reason I did not add it in the first place.

@NoltoxGit
Copy link

Hi,
Do you have any idea when this PR will be merge?

Because after several weeks of testing with this PR on our development server, and we had no special issues.

But, we have had the impression that reloading with the /dmenu reload is a little slower than before. (Maybe it's just an impression!)

@Kqliber Kqliber merged commit 87141c0 into main May 23, 2025
2 checks passed
@Kqliber Kqliber deleted the issue/134 branch May 23, 2025 19:21
Euphillya added a commit to Euphillya/DeluxeMenus-Folia that referenced this pull request Jul 11, 2025
@Euphillya
Update Upstream DeluxeMenus:
2756b25 
HelpChat@a465d9a Fix light_level being overwritten for LIGHT item. (HelpChat#200)
HelpChat@41b2476 Fix MMO-Items not working when item id contains colon(s). (HelpChat#194)
HelpChat@87141c0 Improve metadata / PDC usage (HelpChat#183)
HelpChat@bc699b8 improve bstats (HelpChat#202)
HelpChat@a20c30d update adventure for 1.21.5 (HelpChat#201)
HelpChat@f048028 Fix exception that occurs when trying to add metadata. (HelpChat#205)
HelpChat@08fbb34 fix command event action (HelpChat#206)
HelpChat@d512986 Added support for the new CustomModelDataComponent (HelpChat#195)
HelpChat@4f05d70 Finally, a release (HelpChat#207)
HelpChat@9fc732f Moved to 1.14.2-dev and added CODE_OF_CONDUCT.md & CONTRIBUTING.md files (HelpChat#212)
HelpChat@6775b7f Add Menu Refresh Task and Command for Complete Menu Rebuilding (HelpChat#189)
HelpChat@4ae3bf6 fix README.md link (HelpChat#214)
HelpChat@d884d8d Add gitbook badge (HelpChat#215)
HelpChat@944a113 Add [log] Action to Output Console Messages for Debugging/Testing, Closes HelpChat#199 (HelpChat#208)
HelpChat@94d6632 fix for textures not showing on player name heads (HelpChat#213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kqliber Kqliber Kqliber approved these changes

@Tanguygab Tanguygab Tanguygab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Suggestion] Better metas management
4 participants
@BlitzOffline @NoltoxGit @Kqliber @Tanguygab