Skip to content

Add ARIA landmark roles for screen reader navigation #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mikey-222 merged 2 commits into from
Aug 26, 2026
Merged

Add ARIA landmark roles for screen reader navigation #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc777a0
Add ARIA landmark roles for screen reader navigation
Aug 26, 2026
8ecec09
Merge branch 'main' into a11y/aria-landmarks
wandooadzer-cmyk Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,6 @@ export default function App() {
</div>
</div>
</div>
</header>

<main id="main-content" tabIndex="-1" style={{ outline: "none" }}>
{/* SECTION 2 — PROBLEM */}
Expand Down
10 changes: 8 additions & 2 deletions src/pages/Help.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3520,6 +3520,8 @@ export default function Help() {
<aside
ref={sidebarRef}
id="helphone-help-sidebar"
role="complementary"
aria-label="Request panel"
style={{
width: "340px",
minWidth: "340px",
Expand Down Expand Up @@ -5018,7 +5020,11 @@ export default function Help() {
</div>
</aside>

<div id="helphone-help-map" style={{ flex: 1, position: "relative" }}>
<main
id="helphone-help-map"
aria-label="Emergency map"
style={{ flex: 1, position: "relative" }}
>
<Map
mapboxAccessToken={MAPBOX_TOKEN}
initialViewState={{
Expand Down Expand Up @@ -5845,7 +5851,7 @@ export default function Help() {
)}
</svg>
</button>
</div>
</main>

<ArrivalThanksModal
open={arrivalThanksOpen}
Expand Down
Loading